unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: 27705@debbugs.gnu.org
Subject: [bug#27705] [PATCH v4 2/4] build: Allow mounting of entire disks.
Date: Sat, 5 Aug 2017 19:34:16 +0200	[thread overview]
Message-ID: <20170805193416.26921205@scratchpost.org> (raw)
In-Reply-To: <20170720230648.8205-3-dannym@scratchpost.org>

Okay I'm risking it.  A big reason for magic numbers in all the common superblock types and also in the partition table is that this usecase of optional partition tables works.

I've also excessively tested it.

So I think the risk of breakage is low enough and I've pushed a variant of this patch to master as 9833bcfc08ef009b9e8b4398baa481ef65c80ad7.

I'll be obsessively checking the Guix mailing lists through the next few days - and if it causes problems I'll revert.  Should I be too slow, feel free to revert 9833bcfc08ef009b9e8b4398baa481ef65c80ad7 (only; the other patches of the patchset are independent and aren't a cause of concern).

Since the modified code is part of the system generation one can select the older generation in the Grub boot menu should the new one not work.

  reply	other threads:[~2017-08-05 17:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 13:35 [bug#27705] [PATCH 0/4] Make both EFI and non-EFI systems boot our disk images Danny Milosavljevic
2017-07-15 13:37 ` [bug#27705] [PATCH 1/4] gnu: grub-efi: Add mtools input Danny Milosavljevic
2017-07-15 13:37 ` [bug#27705] [PATCH 2/4] build: Allow mounting of entire disks Danny Milosavljevic
2017-07-15 13:37   ` [bug#27705] [PATCH 3/4] gnu: grub-efi: Add grub Danny Milosavljevic
2017-07-17 18:00     ` Danny Milosavljevic
2017-07-17 21:26     ` Marius Bakke
2017-07-19 20:48       ` Danny Milosavljevic
2017-07-15 13:37   ` [bug#27705] [PATCH 4/4] install: Use grub-efi Danny Milosavljevic
2017-07-17 21:42     ` Danny Milosavljevic
2017-07-20 19:12 ` [bug#27705] [PATCH v2 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images Danny Milosavljevic
2017-07-20 19:12   ` [bug#27705] [PATCH v2 1/4] gnu: grub-efi: Add mtools input Danny Milosavljevic
2017-07-20 19:12   ` [bug#27705] [PATCH v2 2/4] build: Allow mounting of entire disks Danny Milosavljevic
2017-07-20 19:12   ` [bug#27705] [PATCH v2 3/4] gnu: Add grub-hybrid Danny Milosavljevic
2017-07-20 19:12   ` [bug#27705] [PATCH v2 4/4] vm: Use grub-hybrid's grub-mkrescue Danny Milosavljevic
2017-07-20 19:44 ` [bug#27705] [PATCH v3 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images Danny Milosavljevic
2017-07-20 19:44   ` [bug#27705] [PATCH v3 1/4] gnu: grub-efi: Add mtools input Danny Milosavljevic
2017-07-20 19:44   ` [bug#27705] [PATCH v3 2/4] build: Allow mounting of entire disks Danny Milosavljevic
2017-07-20 19:44   ` [bug#27705] [PATCH v3 3/4] gnu: Add grub-hybrid Danny Milosavljevic
2017-07-20 19:44   ` [bug#27705] [PATCH v3 4/4] vm: Use grub-hybrid's grub-mkrescue Danny Milosavljevic
2017-07-20 23:06 ` [bug#27705] [PATCH v4 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images Danny Milosavljevic
2017-07-20 23:06   ` [bug#27705] [PATCH v4 1/4] gnu: grub-efi: Add mtools input Danny Milosavljevic
2017-07-29 17:59     ` Danny Milosavljevic
2017-07-20 23:06   ` [bug#27705] [PATCH v4 2/4] build: Allow mounting of entire disks Danny Milosavljevic
2017-08-05 17:34     ` Danny Milosavljevic [this message]
2017-08-05 21:25       ` Ludovic Courtès
2017-07-20 23:06   ` [bug#27705] [PATCH v4 3/4] gnu: Add grub-hybrid Danny Milosavljevic
2017-08-03 14:36     ` Danny Milosavljevic
2017-07-20 23:06   ` [bug#27705] [PATCH v4 4/4] vm: Use grub-hybrid's grub-mkrescue Danny Milosavljevic
2017-08-03 16:12     ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170805193416.26921205@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27705@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).