unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27893@debbugs.gnu.org
Subject: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2.
Date: Tue, 1 Aug 2017 16:31:40 -0400	[thread overview]
Message-ID: <20170801203140.GA7468@jasmine.lan> (raw)
In-Reply-To: <87379bsjqz.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

On Tue, Aug 01, 2017 at 11:46:44AM +0200, Ludovic Courtès wrote:
> Hi Leo,
> 
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/version-control.scm (libgit2-0.25): New variable.
> > * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0.25.
> > * gnu/packages/patches/libgit2-use-after-free.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
> 
> Sorry for not noticing the breakage!  I wonder if it would be
> easier/safer to fix Julia than to keep the old libgit2.
> 
> Does this upstream commit fix the failures that you saw?

The context of this patch actually doesn't exist in the Julia release.

Based on the very large number of changes to this test between releases,
my impression is that Julia is just not ready for libgit2 0.26.0, even
though there are some commits addressing libgit2 0.26.0 in Julia.

The thing is, I found this test failure building locally but on Hydra
there are different failures [0]. So, even if we fix this issue, we still
probably won't be offering a Julia substitute. Thus, I don't mind
carrying this libgit2-0.25 package privately for now.

[0]
Has anyone got the Julia test suite to pass at all? Spill the beans! :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-08-01 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  0:14 [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2 Leo Famulari
2017-08-01  9:46 ` Ludovic Courtès
2017-08-01 20:31   ` Leo Famulari [this message]
2017-10-18 21:15     ` Ricardo Wurmus
2018-03-07 14:03   ` bug#27893: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801203140.GA7468@jasmine.lan \
    --to=leo@famulari.name \
    --cc=27893@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).