unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 27851@debbugs.gnu.org
Subject: [bug#27851] Update eyed3. ([PATCH 1/2] gnu: Add python-grako)
Date: Thu, 27 Jul 2017 15:33:38 -0400	[thread overview]
Message-ID: <20170727193338.GA18181@jasmine.lan> (raw)
In-Reply-To: <20170727.170446.688232707598375727.post@thomasdanckaert.be>

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Thu, Jul 27, 2017 at 05:04:46PM +0200, Thomas Danckaert wrote:
> Hi Guix,
> 
> I'm sending two patches to update eyed3 to version 0.8 (and switch it over
> to python3).  This patch adds grako, a new requirement for eyed3 0.8.

Cool, thanks!

> Question: do we need a python2 variant for every python package?  At the
> moment, eyed3 is the only package using grako, and I've switched eyed3 to
> python3.  I think it's OK to leave out the python2 versio of grako then (we
> can always add it if a future package needs it)?  For now I included it in
> the patch.

For library or module code, I think we should add both variants if they
both build. They tend to be very cheap to build so there's not a big
downside, in my opinion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-07-27 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 15:04 [bug#27851] Update eyed3. ([PATCH 1/2] gnu: Add python-grako) Thomas Danckaert
2017-07-27 15:18 ` [bug#27851] Update eyed3. ([PATCH 2/2]) Thomas Danckaert
2017-07-27 19:35   ` Leo Famulari
2017-07-27 19:33 ` Leo Famulari [this message]
2017-08-02 12:33   ` bug#27851: Update eyed3. ([PATCH 1/2] gnu: Add python-grako) Thomas Danckaert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170727193338.GA18181@jasmine.lan \
    --to=leo@famulari.name \
    --cc=27851@debbugs.gnu.org \
    --cc=post@thomasdanckaert.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).