From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daIyB-0005yq-3K for guix-patches@gnu.org; Wed, 26 Jul 2017 05:51:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daIy6-0002am-7x for guix-patches@gnu.org; Wed, 26 Jul 2017 05:51:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daIy6-0002aD-4I for guix-patches@gnu.org; Wed, 26 Jul 2017 05:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1daIy5-000073-Pu for guix-patches@gnu.org; Wed, 26 Jul 2017 05:51:01 -0400 Subject: [bug#27650] [PATCH] gnu: services: admin: Add tailon. Resent-Message-ID: Date: Wed, 26 Jul 2017 10:50:09 +0100 From: Christopher Baines Message-ID: <20170726105009.14461c68@cbaines.net> In-Reply-To: <87r2xfbdae.fsf@gnu.org> References: <87shi1etui.fsf@gnu.org> <20170716155226.13689-1-mail@cbaines.net> <87r2xfbdae.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/6z/E.adBz+3LYIQKuHnoKOR"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27650@debbugs.gnu.org --Sig_/6z/E.adBz+3LYIQKuHnoKOR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 17 Jul 2017 11:52:57 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Christopher Baines skribis: >=20 > > * gnu/services/admin.scm > > (, ): New record > > types. (tailon-configuration-files-string, > > tailon-shepherd-service): New procedures. > > (%tailon-accounts, tailon-service-type: New variables. > > * doc/guix.texi (Monitoring Services: Document the Tailon service. =20 >=20 > [...] >=20 > > +@deftp {Data Type} tailon-configuration-file > > +Data type representing the configuration options for Tailon. > > +This type has the following parameters: > > + > > +@table @asis > > +@item @code{files} (default: @code{(list "/var/log")}) > > +List of files to display. The list can include strings for a single > > +file, or a list, where the first item is the name of a subsection, > > and =20 >=20 > s/file/file or directory/ (I assume it recurses into directories?) Yep, it shows the files in the directory. I've sent an updated patch with this change. > > +@item @code{relative-root-path} (default: @code{#f}) > > +Prefix to use for all paths, set to @code{#f} to disable using a > > prefix. =20 >=20 > s/path/directory/ :-) So, it turns out I'd completely misinterpreted this option, I was thinking it was about the log files, as in you would set it to /var/log if you wanted to specify filenames relative to there. That is wrong, its actually about the URL path, so if you want to have Tailon at http://localhost/tailon/ you set the relative-root to /tailon/. I've now updated the code and docs for this. > OK to push with these changes, thank you! I've sent the two patches again. I also was able to debug the issue I was having with the system test, I needed to get Tailon to bind to 0.0.0.0, rather than localhost for it to work, and with that change, the system test works! --Sig_/6z/E.adBz+3LYIQKuHnoKOR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAll4ZdFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xf/HQ//e0dQ30tMHAE7abkYoDB62uFOaDLbn2UFFf982Ho7V5/7Enq76eejZwuw 7PiXfnRK97L6COq/QZpd3N/tBYjjvbz07P9bFhAmNU01TWzX9CyJMVkE9defMnlA V3B/HGallzOlWVoMuYwbiR1NYEnPphpXTps/D/bQPTELjm8mXnnGrUUopYy/ns+h P6+dSg/Qe655waAIwnXrxN51QK5zcnCyi793drKbwpN7yXmLGBOgnvBj0urczJ+e xoDlJAPqR7eZ+paT69aLFMnZ5oHA5VB8sY07gUEARQJxJNofDmMRvma1pPPqr+5U ghffTX463CHLFYiWeOix+PG410XFp6vjKsXe/N36jpUWHPH2HC61lzbmwKSve7lP 2ocATREHwHv8dgkTByo5ib3tYOjn0Xl9z80IwwmCq1iZkkl7mUstIfY0dC8KD8lL brdCDi02qX4HzyBwAhqCcs75s1vmSBoDBqTEO9iHyFjR2vFkdILdOoOn5Xb1Jo4b cudGhsxm6M7Kqz0Dcvuh2uu6bWCUo9fFnyukaRPttS/6ntn9GbpcFDyIZRjhSxkz NiRZFE/KZxGXOkFnz9GIoPUSTJJ9i0cJtbP0GY+mTyvzP6B8Zt6YP4G2ji660W1n 24GqXX+D7e7ghUjcFpG11LKg41xc6VbjXtuNiHpiP/AMWwjDjjg= =miH8 -----END PGP SIGNATURE----- --Sig_/6z/E.adBz+3LYIQKuHnoKOR--