unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27650@debbugs.gnu.org
Subject: [bug#27650] [PATCH] gnu: services: admin: Add tailon.
Date: Wed, 26 Jul 2017 10:50:09 +0100	[thread overview]
Message-ID: <20170726105009.14461c68@cbaines.net> (raw)
In-Reply-To: <87r2xfbdae.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Mon, 17 Jul 2017 11:52:57 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail@cbaines.net> skribis:
> 
> > * gnu/services/admin.scm
> >   (<tailon-configuration>, <tailon-configuration-file>): New record
> > types. (tailon-configuration-files-string,
> > tailon-shepherd-service): New procedures.
> >   (%tailon-accounts, tailon-service-type: New variables.
> > * doc/guix.texi (Monitoring Services: Document the Tailon service.  
> 
> [...]
> 
> > +@deftp {Data Type} tailon-configuration-file
> > +Data type representing the configuration options for Tailon.
> > +This type has the following parameters:
> > +
> > +@table @asis
> > +@item @code{files} (default: @code{(list "/var/log")})
> > +List of files to display. The list can include strings for a single
> > +file, or a list, where the first item is the name of a subsection,
> > and  
> 
> s/file/file or directory/ (I assume it recurses into directories?)

Yep, it shows the files in the directory. I've sent an updated patch
with this change.

> > +@item @code{relative-root-path} (default: @code{#f})
> > +Prefix to use for all paths, set to @code{#f} to disable using a
> > prefix.  
> 
> s/path/directory/ :-)

So, it turns out I'd completely misinterpreted this option, I was
thinking it was about the log files, as in you would set it to /var/log
if you wanted to specify filenames relative to there. That is wrong,
its actually about the URL path, so if you want to have Tailon at
http://localhost/tailon/ you set the relative-root to /tailon/. I've
now updated the code and docs for this.

> OK to push with these changes, thank you!

I've sent the two patches again. I also was able to debug the issue I
was having with the system test, I needed to get Tailon to bind to
0.0.0.0, rather than localhost for it to work, and with that change,
the system test works!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

  reply	other threads:[~2017-07-26  9:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  6:56 [bug#27650] [PATCH] gnu: services: admin: Add tailon Christopher Baines
2017-07-12 12:13 ` Ludovic Courtès
2017-07-16 15:51   ` Christopher Baines
2017-07-17  8:40     ` Ludovic Courtès
2017-07-16 15:52   ` Christopher Baines
2017-07-17  9:52     ` Ludovic Courtès
2017-07-26  9:50       ` Christopher Baines [this message]
2017-07-16 15:58   ` [bug#27650] [PATCH] tests: Add 'tailon-service-type' test Christopher Baines
2017-07-17  9:53     ` Ludovic Courtès
2017-07-26  9:08 ` [bug#27650] [PATCH 1/2] gnu: services: admin: Add tailon Christopher Baines
2017-07-26  9:08   ` [bug#27650] [PATCH 2/2] tests: Add 'tailon-service-type' test Christopher Baines
2017-07-26 20:46     ` Ludovic Courtès
2017-07-27 17:33       ` Christopher Baines
2017-07-27 17:35       ` [bug#27650] [PATCH] gnu: services: admin: Add tailon Christopher Baines
2017-07-28 19:36         ` Ludovic Courtès
2017-07-28 21:00           ` Christopher Baines
2017-07-29 12:00             ` bug#27650: " Christopher Baines
2017-07-29 12:10             ` [bug#27650] " Ludovic Courtès
2017-07-26 20:40   ` [bug#27650] [PATCH 1/2] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726105009.14461c68@cbaines.net \
    --to=mail@cbaines.net \
    --cc=27650@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).