unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ryan Moe <ryan.moe@gmail.com>
Cc: 27784-done@debbugs.gnu.org
Subject: bug#27784: [PATCH] gnu: quassel: Enable SSL
Date: Sat, 22 Jul 2017 20:08:25 -0400	[thread overview]
Message-ID: <20170723000825.GA24840@jasmine.lan> (raw)
In-Reply-To: <20170722141842.8429-1-ryan.moe@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Sat, Jul 22, 2017 at 07:18:42AM -0700, Ryan Moe wrote:

Thanks for this updated patch! I pushed as
36378bd57ec31ba2bbedbdbdbd77b5b0f82f3b8a with the following changes:

I changed all mention of SSL to TLS, which is (optimistically) more
accurate nowadays since all the SSL protocols have been broken and
deprecated.

> This allows quasselclient to connect to SSL-enabled quasselcore
> instances.

I moved this comment into the patch.

> * gnu/packages/patches/quassel-fix-ssl-check.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/irc.scm (quassel)[arguments]: Use it.

s/arguments/source

> diff --git a/gnu/packages/patches/quassel-fix-ssl-check.patch b/gnu/packages/patches/quassel-fix-ssl-check.patch
> new file mode 100644
> index 000000000..14c57883f
> --- /dev/null
> +++ b/gnu/packages/patches/quassel-fix-ssl-check.patch
> @@ -0,0 +1,23 @@
> +The check in qglobal.h requires -fPIC (not -fPIE as it
> +is now). When this check fails SSL is disabled.
> +
> +This patch comes from upstream master [0] and can be removed
> +when the next version is packaged.
> +
> +[0] https://github.com/quassel/quassel/commit/4768c9e99

I used the full commit hash here.

Plus various stylistic and cosmetic changes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-07-23  0:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 20:12 [bug#27784] [PATCH] gnu: quassel: Enable SSL Ryan Moe
2017-07-22 12:37 ` Marius Bakke
2017-07-22 14:18 ` Ryan Moe
2017-07-23  0:08   ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170723000825.GA24840@jasmine.lan \
    --to=leo@famulari.name \
    --cc=27784-done@debbugs.gnu.org \
    --cc=ryan.moe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).