From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYqnU-0000He-Vf for guix-patches@gnu.org; Sat, 22 Jul 2017 05:34:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYqnR-0005sC-RG for guix-patches@gnu.org; Sat, 22 Jul 2017 05:34:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYqnR-0005s7-OB for guix-patches@gnu.org; Sat, 22 Jul 2017 05:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYqnR-00083z-IS for guix-patches@gnu.org; Sat, 22 Jul 2017 05:34:01 -0400 Subject: [bug#27249] [PATCH] gnu: gnome: Add deja-dup. Resent-Message-ID: Date: Sat, 22 Jul 2017 10:33:51 +0100 From: Christopher Baines Message-ID: <20170722103351.06f40102@cbaines.net> In-Reply-To: <87pocvwj84.fsf@gnu.org> References: <20170605071241.1825-1-mail@cbaines.net> <87r2yw2bq7.fsf@gnu.org> <87pocvwj84.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/bbTCLGPD1SnSGuXNxapVnQJ"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27249@debbugs.gnu.org --Sig_/bbTCLGPD1SnSGuXNxapVnQJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 20 Jul 2017 11:28:11 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Heya Christopher, >=20 > Christopher Baines skribis: >=20 > > On 07/06/17 14:01, Ludovic Court=C3=A8s wrote: =20 > >> Christopher Baines skribis: > >> =20 > >>> * gnu/packages/gnome.scm (deja-dup): New variable. =20 > >>=20 > >> There=E2=80=99s a couple of lint warnings fixed by the patch below: =20 >=20 > [...] >=20 > >> Regarding propagated inputs: > >> =20 > >>> + (propagated-inputs > >>> + `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > >>> + ("gobject-introspection" ,gobject-introspection) > >>> + ("duplicity" ,duplicity) > >>> + ("python" ,python2-minimal) > >>> + ("python-pygobject" ,python2-pygobject))) =20 > >>=20 > >> Could you add a comment explaining why all this needs to be > >> propagated? If there=E2=80=99s a way to avoid it, it=E2=80=99s even be= tter (for > >> instance, if deja-dup execs duplicity, we could hard-code the > >> absolute file name of duplicity.) =20 > > > > Thanks for your review Ludo, hopefully I can get around to looking > > at deja-dup again at the weekend :) =20 >=20 > It=E2=80=99s been a long week-end. ;-) Could you take a look again so w= e can > save this patch from bitrot? Yep, its so long ago, I forget what I ended up doing that weekend! I've sent another patch now. I think vala and dbus may have moved in the mean time, so this one includes a patch from upstream to fix compilation issues with vala 0.36, and the check stage had to be disabled, as the tests no longer pass due to an issue with DBus. As for the propagated-inputs, I made them all inputs, and tested the application, and I couldn't see any problems. --Sig_/bbTCLGPD1SnSGuXNxapVnQJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAllzG/9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfT/A/+ItKvBfLuPYoh584Q5ri4hRUv6GF46bNWZ7a5qiw65L1B6K5eoiJYnWc0 5bk9CLmD7oYjS5FjvopTFH1fv30BpKO3dRfOcAyHMtTjJZFh5FFMWNoj46/i71xS rJrvleCobyYFsF32SyTj3r++TghDgi+P2CThi6gd5QC7oa5urt5ZSZwg3AWt1fRW JJihT/2Bd/jkL+aB8jxd5MnLYQ5TsmwRBAkj3RapNjOS1VtCEBA3t4uyI/prbT+q s3eobAdivEXUY819JNSGY6jG7VfniPfv8pAuS8Wh76uNZzwQqSs9A3k8qNWRFn3Q 3eLjLMcaKWNnLbs4SCYNtTKj8h7srKfDXmZjw9erAKetZXkCC3RdeCGARZU8GNer tbpdO2dRnQ63fkQviMo5JtxjDkBHgW7X1wj648BDu+D9RL86b0dQ1VAfdB1iu0XV kFx5BuCQp3sfZGTWRB30pe/GV9OJQ3zu5BKpfEGucozwkKjSgz22Eft/Jb/WkdqD Mq6eOAWu4xoUxV7/LtN0g5YHQ3jJTCOZc572yt628Rlg3WuQBgies/ZxXEUQRbYd qCHa7hpNYT5/1pgIhvugxY3LXfS33sKHSye9e7AzGl5VFXKF8U7+rKJxi1E91X82 Y4GwwOkQKvMaxhdXi8hu5JdBc148P2xZfZbnKqW6VTN4E3xTxh0= =HSo2 -----END PGP SIGNATURE----- --Sig_/bbTCLGPD1SnSGuXNxapVnQJ--