From: Christopher Baines <mail@cbaines.net>
To: "Ben Woodcroft" <b.woodcroft@uq.edu.au>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: 27438@debbugs.gnu.org
Subject: [bug#27438] [PATCH] Specify native search path for all ruby packages
Date: Sun, 16 Jul 2017 18:37:05 +0100 [thread overview]
Message-ID: <20170716183705.18b5025e@cbaines.net> (raw)
In-Reply-To: <6a666d6f-f2c2-d786-8fda-422ab28867ca@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 4583 bytes --]
On Thu, 22 Jun 2017 06:40:17 +0100
Christopher Baines <mail@cbaines.net> wrote:
> On 22/06/17 06:27, Ben Woodcroft wrote:
> > On 21/06/17 23:12, Ludovic Courtès wrote:
> >> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
> >>
> >>> On 21/06/17 16:36, Christopher Baines wrote:
> >>>> Without specifying this explicitly in each definition, the
> >>>> GEM_PATH is inherited and the version is that of the inherited
> >>>> package.
> >>> I'm not sure if this is by design, but the version of the gems
> >>> folder is embedded in the build of each rubygem e.g. 'ruby-hoe'
> >>> includes /gnu/store/d867l5i2dqd5qnq4qlsrcwwb0x3443fl-ruby-hoe-3.16.0/lib/ruby/gems/2.4.0
> >>>
> >> Or should the search path spec include both lib/ruby/gems/2.2.0 and
> >> lib/ruby/gems/2.4.0, in this order?
> > Exactly.
> >
> > Chris, what is your experience? Did you propose the patch because
> > you ran into a particular issue?
>
> Yep, I ran in to problems trying to use the guix ruby-2.3 package with
> the guix bundler package, when I build bundler with ruby-2.3.
>
> Ben's email got me thinking about how this works in Debian, and it
> looks like Debian uses a different
> location /usr/lib/ruby/vendor_ruby/ .
>
> I think there might be benefits from doing similarly, but this needs a
> bit of thought and testing, as I'm unsure how this might work,
> especially in cases where libraries include native code that links
> against ruby.
>
> I've got a patch for the ruby-build-system to make a change roughly
> like this, and I'll send that up soon. Relating this back to the
> issue at hand, moving to a version independent directory would mean
> that the GEM_PATH wouldn't be version specific.
So... I kind of forgot about this, sorry about that. But I'll send up
the patch shortly.
As an example of what this change means, here is a example of loading
ruby gems with different versions of ruby, with the current and
alternative situations.
I think arel doesn't use native extensions, whereas nokogiri does.
Also, ruby@2.1 is used, as the search path for the guix package
reflects the version of ruby (whereas many others don't).
* Current
** With the version of ruby used to build the gem
→ guix environment --pure --ad-hoc ruby-arel ruby -- ruby -e "puts require 'arel'"
true
(I'm pretty sure the "true" means that it worked)
→ guix environment --pure --ad-hoc ruby-nokogiri ruby -- ruby -e "puts require 'nokogiri'"
true
** With a different version of ruby
→ guix environment --pure --ad-hoc ruby-arel ruby@2.1 -- ruby -e "puts require 'arel'"
/gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- arel (LoadError)
from /gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
from -e:1:in `<main>'
→ guix environment --pure --ad-hoc ruby-arel ruby@2.1 -- ruby -e "puts require 'nokogiri'"
/gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- nokogiri (LoadError)
from /gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
from -e:1:in `<main>'
* Alternative
** With the version of ruby used to build the gem
→ guix environment --pure --ad-hoc ruby-arel ruby -- ruby -e "puts require 'arel'"
true
→ guix environment --pure --ad-hoc ruby-nokogiri ruby -- ruby -e "puts require 'nokogiri'"
true
** With a different version of ruby
→ guix environment --pure --ad-hoc ruby-arel ruby@2.1 -- ruby -e "puts require 'arel'"
true
→ guix environment --pure --ad-hoc ruby-nokogiri ruby@2.1 -- ruby -e "puts require 'nokogiri'"
/gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/fileutils.rb:250:in `mkdir': Read-only file system @ dir_s_mkdir - /gnu/store/jxmi5lr8dbll3pzlzwkafpd9mj1wwxma-profile/lib/ruby/vendor_ruby/extensions/x86_64-linux/2.1.0-static (Errno::EROFS)
from /gnu/store/gdg5m75axmrciwh3zhfnsc038q349ymg-ruby-2.1.10/lib/ruby/2.1.0/fileutils.rb:250:in `fu_mkdir'
...
So, putting the gems in a single location regardless of the version of
ruby they were built with means that a different version of ruby will
at least see them, however, it may still fail to load them.
I think this is an improvement, but I'm very uncertain about ruby. Does
anyone else have opinions on this?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-07-16 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 6:36 [bug#27438] [PATCH] Specify native search path for all ruby packages Christopher Baines
2017-06-21 6:38 ` [bug#27438] [PATCH 1/3] gnu: ruby-1.8: Fix search path specification Christopher Baines
2017-06-21 6:38 ` [bug#27438] [PATCH 2/3] gnu: ruby-2.2: " Christopher Baines
2017-06-21 6:38 ` [bug#27438] [PATCH 3/3] gnu: ruby-2.3: " Christopher Baines
2017-06-21 11:47 ` [bug#27438] [PATCH] Specify native search path for all ruby packages Ben Woodcroft
2017-06-21 13:12 ` Ludovic Courtès
2017-06-22 5:27 ` Ben Woodcroft
2017-06-22 5:40 ` Christopher Baines
2017-07-16 17:37 ` Christopher Baines [this message]
2017-07-16 17:40 ` [bug#27438] [PATCH] guix: build: ruby-build-system: Install to the vendor directory Christopher Baines
2017-07-19 23:39 ` [bug#27438] [PATCH] Specify native search path for all ruby packages Ben Woodcroft
2017-07-22 10:06 ` Christopher Baines
2017-08-05 3:59 ` Ben Woodcroft
2017-08-05 21:55 ` Christopher Baines
2017-08-06 7:17 ` Ben Woodcroft
2017-06-21 13:10 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170716183705.18b5025e@cbaines.net \
--to=mail@cbaines.net \
--cc=27438@debbugs.gnu.org \
--cc=b.woodcroft@uq.edu.au \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).