From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW55P-0004y7-BS
	for guix-patches@gnu.org; Fri, 14 Jul 2017 14:13:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW55M-0001Ba-6D
	for guix-patches@gnu.org; Fri, 14 Jul 2017 14:13:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36607)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dW55M-0001BS-1n
	for guix-patches@gnu.org; Fri, 14 Jul 2017 14:13:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW55K-0002m2-A7
	for guix-patches@gnu.org; Fri, 14 Jul 2017 14:13:03 -0400
Subject: [bug#27689] [PATCH] gnu: grub-efi: Add mtools input.
Resent-Message-ID: <handler.27689.B27689.150005594410618@debbugs.gnu.org>
Date: Fri, 14 Jul 2017 20:12:15 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170714201215.7f6e0dc4@scratchpost.org>
In-Reply-To: <878tjrj757.fsf@fastmail.com>
References: <20170714065842.5665-1-dannym@scratchpost.org>
	<878tjrj757.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27689@debbugs.gnu.org

Hi Marius,

On Fri, 14 Jul 2017 18:49:24 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > * gnu/packages/bootloaders.scm: Add (gnu packages mtools).
> > (grub-efi)[inputs]: Add mtools.
> > [arguments]: Add phase "use-absolute-mtools-path".  
> 
> Why is this only necessary for grub-efi?

I checked the grub source code and mformat and mcopy are only used in util/grub-mkrescue.c if source_dirs[GRUB_INSTALL_PLATFORM_*_EFI].

If that's too fine-grained, we can also add it to grub itself.  But I'm sure it's only used for grub-mkrescue in the case of EFI.

> > +               (add-after 'patch-stuff 'use-absolute-mtools-path
> > +                 (lambda* (#:key inputs #:allow-other-keys)
> > +                   (let ((mtools (assoc-ref inputs"mtools")))  
>                                                     ^^^
> Missing space.

Thanks :)