unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27689@debbugs.gnu.org
Subject: [bug#27689] [PATCH] gnu: grub-efi: Add mtools input.
Date: Fri, 14 Jul 2017 20:12:15 +0200	[thread overview]
Message-ID: <20170714201215.7f6e0dc4@scratchpost.org> (raw)
In-Reply-To: <878tjrj757.fsf@fastmail.com>

Hi Marius,

On Fri, 14 Jul 2017 18:49:24 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > * gnu/packages/bootloaders.scm: Add (gnu packages mtools).
> > (grub-efi)[inputs]: Add mtools.
> > [arguments]: Add phase "use-absolute-mtools-path".  
> 
> Why is this only necessary for grub-efi?

I checked the grub source code and mformat and mcopy are only used in util/grub-mkrescue.c if source_dirs[GRUB_INSTALL_PLATFORM_*_EFI].

If that's too fine-grained, we can also add it to grub itself.  But I'm sure it's only used for grub-mkrescue in the case of EFI.

> > +               (add-after 'patch-stuff 'use-absolute-mtools-path
> > +                 (lambda* (#:key inputs #:allow-other-keys)
> > +                   (let ((mtools (assoc-ref inputs"mtools")))  
>                                                     ^^^
> Missing space.

Thanks :)

      reply	other threads:[~2017-07-14 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-14  6:58 [bug#27689] [PATCH] gnu: grub-efi: Add mtools input Danny Milosavljevic
2017-07-14 16:49 ` Marius Bakke
2017-07-14 18:12   ` Danny Milosavljevic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170714201215.7f6e0dc4@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27689@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).