[bug#27672] oksh

[bug#27672] oksh

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 307 bytes --]

This adds oksh.

The test phase is a FIXME
and the make install has some nonfatal error I did not bother
to fix because the resulting application works.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-Add-oksh.patch --]
[-- Type: text/plain, Size: 2053 bytes --]

From 45e8b007cc8e7eba10585980ad31a89d42689b75 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Wed, 12 Jul 2017 19:32:51 +0000
Subject: [PATCH] gnu: Add oksh.

* gnu/packages/shells.scm (oksh): New variable.
---
 gnu/packages/shells.scm | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 65e0eda50..4cc812447 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2016 Stefan Reichör <stefan@xsteve.at>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2017 ng0 <ng0@no-reply.infotropique.org>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -564,6 +564,32 @@ extra programs.  > is just another unix command, < is essentially cat(1).
 A @code{andglob} program is also provided along with s.")
       (license bsd-3))))
 
+(define-public oksh
+  (package
+    (name "oksh")
+    (version "0.5.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://connochaetos.org/oksh/oksh-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0ln9yf6pxngsviqszv8klnnvn8vcpplvj1njdn8xr2y8frkbw8r3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(; FIXME:
+       ;; starting phase `check'
+       ;;./tests/th-sh ./tests/th -s ./tests -p ./ksh -C pdksh,sh,ksh,posix,posix-upu
+       ;; make: ./tests/th-sh: Command not found
+       #:tests? #f))
+    (home-page "https://connochaetos.org/oksh")
+    (synopsis "Port of OpenBSD Korn Shell")
+    (description
+     "Oksh is a port of the OpenBSD Korn Shell.
+The OpenBSD Korn Shell is a cleaned up and enhanced ksh.")
+    (license gpl3+)))
+
 (define-public loksh
   (package
     (name "loksh")
-- 
2.13.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#27672] oksh

[Arun Isaac]

ng0 writes:

> +    (arguments
> +     `(; FIXME:
> +       ;; starting phase `check'
> +       ;;./tests/th-sh ./tests/th -s ./tests -p ./ksh -C pdksh,sh,ksh,posix,posix-upu
> +       ;; make: ./tests/th-sh: Command not found
> +       #:tests? #f))

Actually, the test files are not present in the tarball. Look at line 62
of the Makefile listing all the test files. None of those files
exist. Also, look at the check target on line 99.

LGTM, otherwise!

[bug#27672] oksh

[ng0]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Arun Isaac transcribed 0.5K bytes:
> 
> ng0 writes:
> 
> > +    (arguments
> > +     `(; FIXME:
> > +       ;; starting phase `check'
> > +       ;;./tests/th-sh ./tests/th -s ./tests -p ./ksh -C pdksh,sh,ksh,posix,posix-upu
> > +       ;; make: ./tests/th-sh: Command not found
> > +       #:tests? #f))
> 
> Actually, the test files are not present in the tarball. Look at line 62
> of the Makefile listing all the test files. None of those files
> exist. Also, look at the check target on line 99.

I will take another look and maybe patch it out and/or contact upstream.
Thanks!

> LGTM, otherwise!
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#27672] oksh

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 246 bytes --]

Updated patch appended.

I'll contact upstream and ask about the missing test files.
Thanks!
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-Add-oksh.patch --]
[-- Type: text/plain, Size: 1952 bytes --]

From 5d8035dddb5037b0fe5f856f14f7b5190f14b3c2 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Wed, 12 Jul 2017 19:32:51 +0000
Subject: [PATCH] gnu: Add oksh.

* gnu/packages/shells.scm (oksh): New variable.
---
 gnu/packages/shells.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index c66c575c1..8d2a957ea 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2016 Stefan Reichör <stefan@xsteve.at>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2017 ng0 <ng0@no-reply.infotropique.org>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
 ;;;
@@ -553,6 +553,29 @@ extra programs.  > is just another unix command, < is essentially cat(1).
 A @code{andglob} program is also provided along with s.")
       (license bsd-3))))
 
+(define-public oksh
+  (package
+    (name "oksh")
+    (version "0.5.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://connochaetos.org/oksh/oksh-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0ln9yf6pxngsviqszv8klnnvn8vcpplvj1njdn8xr2y8frkbw8r3"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(; The test files are not part of the distributed tarball.
+       #:tests? #f))
+    (home-page "https://connochaetos.org/oksh")
+    (synopsis "Port of OpenBSD Korn Shell")
+    (description
+     "Oksh is a port of the OpenBSD Korn Shell.
+The OpenBSD Korn Shell is a cleaned up and enhanced ksh.")
+    (license gpl3+)))
+
 (define-public loksh
   (package
     (name "loksh")
-- 
2.13.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27672: oksh

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

On Sat, Jul 22, 2017 at 09:31:03AM +0000, ng0 wrote:
> Updated patch appended.
> 
> I'll contact upstream and ask about the missing test files.
> Thanks!
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://n0is.noblogs.org/my-keys
> https://www.infotropique.org https://krosos.org

> From 5d8035dddb5037b0fe5f856f14f7b5190f14b3c2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Wed, 12 Jul 2017 19:32:51 +0000
> Subject: [PATCH] gnu: Add oksh.
> 
> * gnu/packages/shells.scm (oksh): New variable.

Thanks! Pushed as 7e3c977da6ea15acfad361200cdde12636406b61.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]