* [bug#27673] [PATCH] gnu: Add emacs-org-pomodoro.
@ 2017-07-12 20:47 Oleg Pykhalov
2017-07-14 11:55 ` Arun Isaac
[not found] ` <52c335a3.AEQANFFEJwgAAAAAAAAAAAPNhpIAAAACwQwAAAAAAAW9WABZaLFC@mailjet.com>
0 siblings, 2 replies; 7+ messages in thread
From: Oleg Pykhalov @ 2017-07-12 20:47 UTC (permalink / raw)
To: 27673
* gnu/packages/emacs.scm (emacs-org-pomodoro): New variable.
---
gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 75122af8b..551dfa1c7 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2514,6 +2514,29 @@ number.")
@code{org-mode} to be rendered as UTF-8 characters.")
(license license:gpl3+)))
+(define-public emacs-org-pomodoro
+ (package
+ (name "emacs-org-pomodoro")
+ (version "2.1.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/lolownia/org-pomodoro/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1jalsggw3q5kvj353f84x4nl04a5vmq07h75ggppy1627lb31zm4"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-alert" ,emacs-alert)))
+ (home-page "https://github.com/lolownia/org-pomodoro")
+ (synopsis "Pomodoro technique for org-mode")
+ (description
+ "@code{emacs-org-pomodoro} adds very basic support for Pomodoro technique
+in Emacs org-mode.")
+ (license license:gpl3+)))
+
(define-public emacs-org-trello
(package
(name "emacs-org-trello")
--
2.13.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#27673] [PATCH] gnu: Add emacs-org-pomodoro.
2017-07-12 20:47 [bug#27673] [PATCH] gnu: Add emacs-org-pomodoro Oleg Pykhalov
@ 2017-07-14 11:55 ` Arun Isaac
[not found] ` <52c335a3.AEQANFFEJwgAAAAAAAAAAAPNhpIAAAACwQwAAAAAAAW9WABZaLFC@mailjet.com>
1 sibling, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2017-07-14 11:55 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 27673
Thanks for the patch!
> +(define-public emacs-org-pomodoro
> + (package
> + (name "emacs-org-pomodoro")
> + (version "2.1.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/lolownia/org-pomodoro/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1jalsggw3q5kvj353f84x4nl04a5vmq07h75ggppy1627lb31zm4"))))
> + (build-system emacs-build-system)
Could you also package the tests? You'll need something very similar to
what the emacs-which-key package has.
> + (propagated-inputs
> + `(("emacs-alert" ,emacs-alert)))
> + (home-page "https://github.com/lolownia/org-pomodoro")
> + (synopsis "Pomodoro technique for org-mode")
> + (description
> + "@code{emacs-org-pomodoro} adds very basic support for Pomodoro technique
> +in Emacs org-mode.")
Could you extend the description a little more, perhaps by paraphrasing
paragraph 3 of README.md...?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#27673] Failing tests
[not found] ` <52c335a3.AEQANFFEJwgAAAAAAAAAAAPNhpIAAAACwQwAAAAAAAW9WABZaLFC@mailjet.com>
@ 2017-07-14 13:49 ` Oleg Pykhalov
2017-07-14 14:11 ` Arun Isaac
0 siblings, 1 reply; 7+ messages in thread
From: Oleg Pykhalov @ 2017-07-14 13:49 UTC (permalink / raw)
To: Arun Isaac; +Cc: 27673
Arun Isaac <arunisaac@systemreboot.net> writes:
> Could you also package the tests? You'll need something very similar to
> what the emacs-which-key package has.
Sure, but they fails :-)
(arguments
`(#:phases
(modify-phases %standard-phases
(add-before 'install 'check
(lambda _
(zero? (system* "emacs" "--batch" "-L" "."
"-l" "org-pomodoro-tests.el"
"-f" "ert-run-tests-batch-and-exit")))))))
Running 2 tests (2017-07-14 13:09:26+0000)
Test org-pomodoro-expires-when-last-clockin-is-new backtrace:
(let ((fn-5 (function equal)) (args-6 (list nil (org-pomodoro-expire
(let ((org-pomodoro-last-clock-in (current-time)) (org-pomodoro-expi
(lambda nil (let ((org-pomodoro-last-clock-in (current-time)) (org-p
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test org-pomodoro-expires-when-last-cloc
ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test o
ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\0\211@\20
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-L" "." "-l" "org-pomodoro-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test org-pomodoro-expires-when-last-clockin-is-new condition:
(void-function org-pomodoro-expires-p)
FAILED 1/2 org-pomodoro-expires-when-last-clockin-is-new
Test org-pomodoro-expires-when-last-clockin-too-old backtrace:
(let ((fn-0 (function equal)) (args-1 (list t (org-pomodoro-expires-
(let ((org-pomodoro-last-clock-in (quote (0 120 0 0))) (org-pomodoro
(lambda nil (let ((org-pomodoro-last-clock-in (quote (0 120 0 0))) (
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test org-pomodoro-expires-when-last-cloc
ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test o
ert-run-tests(t #[385 "\306\307\"\203G\211\211G\310U\203\0\211@\20
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit()
command-line-1(("-L" "." "-l" "org-pomodoro-tests.el" "-f" "ert-run-
command-line()
normal-top-level()
Test org-pomodoro-expires-when-last-clockin-too-old condition:
(void-function org-pomodoro-expires-p)
FAILED 2/2 org-pomodoro-expires-when-last-clockin-too-old
Ran 2 tests, 0 results as expected, 2 unexpected (2017-07-14 13:09:26+0000)
2 unexpected results:
FAILED org-pomodoro-expires-when-last-clockin-is-new
FAILED org-pomodoro-expires-when-last-clockin-too-old
>> + (propagated-inputs
>> + `(("emacs-alert" ,emacs-alert)))
>> + (home-page "https://github.com/lolownia/org-pomodoro")
>> + (synopsis "Pomodoro technique for org-mode")
>> + (description
>> + "@code{emacs-org-pomodoro} adds very basic support for Pomodoro technique
>> +in Emacs org-mode.")
>
> Could you extend the description a little more, perhaps by paraphrasing
> paragraph 3 of README.md...?
Sure, I think it's appropriate:
@code{emacs-org-pomodoro} adds very basic support for Pomodoro technique
in Emacs org-mode.
Run @code{M-x org-pomodoro} for the task at point or select one of the
last tasks that you clocked time for. Each clocked-in pomodoro starts a
timer of 25 minutes and after each pomodoro a break timer of 5 minutes
is started automatically. Every 4 breaks a long break is started with
20 minutes. All values are customizable.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#27673] Failing tests
2017-07-14 13:49 ` [bug#27673] Failing tests Oleg Pykhalov
@ 2017-07-14 14:11 ` Arun Isaac
2017-07-14 15:12 ` Leo Famulari
0 siblings, 1 reply; 7+ messages in thread
From: Arun Isaac @ 2017-07-14 14:11 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 27673
Oleg Pykhalov writes:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>> Could you also package the tests? You'll need something very similar to
>> what the emacs-which-key package has.
>
> Sure, but they fails :-)
Sure, we'll ditch the tests. Could you just send me an updated patch
with the new description?
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#27673] Failing tests
2017-07-14 14:11 ` Arun Isaac
@ 2017-07-14 15:12 ` Leo Famulari
2017-07-14 16:34 ` Oleg Pykhalov
0 siblings, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2017-07-14 15:12 UTC (permalink / raw)
To: Arun Isaac; +Cc: 27673
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Fri, Jul 14, 2017 at 07:41:25PM +0530, Arun Isaac wrote:
>
> Oleg Pykhalov writes:
>
> > Arun Isaac <arunisaac@systemreboot.net> writes:
> >> Could you also package the tests? You'll need something very similar to
> >> what the emacs-which-key package has.
> >
> > Sure, but they fails :-)
>
> Sure, we'll ditch the tests. Could you just send me an updated patch
> with the new description?
Do the test failures indicate a real problem with the package? Or are
they spurious? Should we report them upstream?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#27673] Failing tests
2017-07-14 15:12 ` Leo Famulari
@ 2017-07-14 16:34 ` Oleg Pykhalov
2017-07-17 9:46 ` bug#27673: " Arun Isaac
0 siblings, 1 reply; 7+ messages in thread
From: Oleg Pykhalov @ 2017-07-14 16:34 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27673
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
Arun Isaac <arunisaac@systemreboot.net> writes:
> Sure, we'll ditch the tests. Could you just send me an updated patch
> with the new description?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Improve description --]
[-- Type: text/x-patch, Size: 1919 bytes --]
From 8c0c77b34b12bffd32947691ee365922ed6f79fb Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 12 Jul 2017 18:30:56 +0300
Subject: [PATCH] gnu: Add emacs-org-pomodoro.
* gnu/packages/emacs.scm (emacs-org-pomodoro): New variable.
---
gnu/packages/emacs.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 75122af8b..e2ef257ec 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2514,6 +2514,35 @@ number.")
@code{org-mode} to be rendered as UTF-8 characters.")
(license license:gpl3+)))
+(define-public emacs-org-pomodoro
+ (package
+ (name "emacs-org-pomodoro")
+ (version "2.1.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/lolownia/org-pomodoro/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1jalsggw3q5kvj353f84x4nl04a5vmq07h75ggppy1627lb31zm4"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-alert" ,emacs-alert)))
+ (home-page "https://github.com/lolownia/org-pomodoro")
+ (synopsis "Pomodoro technique for org-mode")
+ (description
+ "@code{emacs-org-pomodoro} adds very basic support for Pomodoro
+technique in Emacs org-mode.
+
+Run @code{M-x org-pomodoro} for the task at point or select one of the
+last tasks that you clocked time for. Each clocked-in pomodoro starts
+a timer of 25 minutes and after each pomodoro a break timer of 5
+minutes is started automatically. Every 4 breaks a long break is
+started with 20 minutes. All values are customizable.")
+ (license license:gpl3+)))
+
(define-public emacs-org-trello
(package
(name "emacs-org-trello")
--
2.13.2
[-- Attachment #3: Type: text/plain, Size: 332 bytes --]
Leo Famulari <leo@famulari.name> writes:
> Do the test failures indicate a real problem with the package? Or are
> they spurious? Should we report them upstream?
No, I think they fail because checked variables are not defined during
test and even during running Emacs session. I passed the test manually
evaluate them in Emacs.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#27673: Failing tests
2017-07-14 16:34 ` Oleg Pykhalov
@ 2017-07-17 9:46 ` Arun Isaac
0 siblings, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2017-07-17 9:46 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 27673-done
I have pushed the patch. Thanks!
@Oleg:
Could you report the failing tests upstream?
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-17 9:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-12 20:47 [bug#27673] [PATCH] gnu: Add emacs-org-pomodoro Oleg Pykhalov
2017-07-14 11:55 ` Arun Isaac
[not found] ` <52c335a3.AEQANFFEJwgAAAAAAAAAAAPNhpIAAAACwQwAAAAAAAW9WABZaLFC@mailjet.com>
2017-07-14 13:49 ` [bug#27673] Failing tests Oleg Pykhalov
2017-07-14 14:11 ` Arun Isaac
2017-07-14 15:12 ` Leo Famulari
2017-07-14 16:34 ` Oleg Pykhalov
2017-07-17 9:46 ` bug#27673: " Arun Isaac
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).