From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27412@debbugs.gnu.org
Subject: [bug#27412] [PATCH] gnu: rustc: Enable tests.
Date: Sun, 18 Jun 2017 19:28:34 +0200 [thread overview]
Message-ID: <20170618192834.5181cebe@scratchpost.org> (raw)
In-Reply-To: <87shixfexf.fsf@fastmail.com>
Hi Marius,
On Sun, 18 Jun 2017 18:17:48 +0200
Marius Bakke <mbakke@fastmail.com> wrote:
> > + (("\"/bin/sh\"") (string-append "
> > +\"" bash "/bin/sh\"")))
>
> Can you use '\n' instead?
No idea. I don't really use '\n' in Guile at all. I'll try it...
> > + (substitute* "src/libstd/sys/unix/process/process_common.rs"
> > + (("fn test_process_mask") "#[cfg_attr(target_os = \"linux\", ignore)]
> > +fn test_process_mask"))
>
> I'm guessing this is disabled due to some build container oddity?
Yeah. Strangely enough if I manually run the tests in "guix environment -C -N", it works. WTF?
See <https://lists.gnu.org/archive/html/guix-devel/2017-06/msg00222.html>.
> > + (substitute* "src/vendor/libc/src/lib.rs"
> > + (("TODO") "TXDO"))
I think this was a false flag and it works without that substitution. I'll try...
> > + ;; Our ld-wrapper cannot process non-UTF8 bytes in LIBRARY_PATH.
> > + (delete-file-recursively "src/test/run-make/linker-output-non-utf8")
>This is temporary, right?
Not really. I think Guile will continue to convert char* to Unicode UCS-4 (or similar) strings - so I don't see how that's ever going to change. What this Rust test does is it explicitly uses a NON-Unicode character (as in 0xFF) to make sure that that works, too.
I'm not sure what the use case is for that...
See <https://lists.gnu.org/archive/html/guix-devel/2017-06/msg00193.html>.
>Maybe add the guix-devel URL?
I'll add links to these archive entries as comments, and try without the "TODO" substitution and if all is well then I'll push to master (building takes ≈ 4 h per round, so no hurry).
Thanks for the review!
prev parent reply other threads:[~2017-06-18 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 18:37 [bug#27412] [PATCH] gnu: rustc: Enable tests Danny Milosavljevic
2017-06-18 16:17 ` Marius Bakke
2017-06-18 17:28 ` Danny Milosavljevic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618192834.5181cebe@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=27412@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).