unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@infotropique.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 25728@debbugs.gnu.org
Subject: [bug#25728] [PATCH 2/2] gnu: Add colorforth.
Date: Sun, 18 Jun 2017 11:59:47 +0000	[thread overview]
Message-ID: <20170618115947.jo22jym5bm6semng@abyayala> (raw)
In-Reply-To: <87d1a17e94.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 3181 bytes --]

Ricardo Wurmus transcribed 2.5K bytes:
> 
> ng0 <contact.ng0@cryptolab.net> writes:
> 
> > Version two of the patches attached.
> > --
> […]
> 
> >>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001
> > From: ng0 <ngillmann@runbox.com>
> > Date: Thu, 6 Oct 2016 22:31:46 +0000
> > Subject: [PATCH 2/2] gnu: Add colorforth.
> >
> > * gnu/packages/forth.scm (colorforth): New variable.
> > ---
> […]
> > +
> > +(define-public colorforth
> > +  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
> > +        (revision "1"))
> > +    (package
> > +      (name "colorforth")
> > +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url "https://github.com/narke/colorForth")
> > +                      (commit commit)))
> > +                (sha256
> > +                 (base32
> > +                  "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
> > +      (arguments
> > +       `(#:tests? #f
> 
> There should be a comment to explain why tests are disabled.
> 
> > +         #:phases
> > +         (modify-phases %standard-phases
> > +           (delete 'configure) ;No configure script
> > +           (replace 'install ;No install target
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (install-file "cf2012.img"
> > +                             (string-append (assoc-ref outputs "out")
> > +                                            "/bin"))
> > +               #t)))))
> 
> If I understood this correctly, this is not an executable.  One is
> supposed to run this with qemu.  This means that it doesn’t belong in
> “bin”.

Could you propose a directory? I would pick 'share/colorforth/'.

> > +      (native-inputs
> > +       `(("nasm" ,nasm)))
> > +      (build-system gnu-build-system)
> > +      (home-page "https://github.com/narke/colorForth")
> > +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> > +      (description
> > +       "Colorforth is a @code{colorForth} implementation written in
> > +x86 assembly.  It is a dialect of Forth that uses color to replace
> > +punctation, includes its own operating system and produces extremely
> > +compact programs.  Applications compile from pre-parsed source.
> > +Colorforth applications can be run using @code{Bochs} and @code{Qemu}.
> > +It is adapted from @url{http://sourceforge.net/projects/colorforth,
> > +colorforth}.")
> > +      (license license:public-domain))))
> 
> I could not find a license statement anywhere in the repository.  How do
> you know it’s public domain software?

I think I assumed by the software it was based on.
Great, one of these github-style software productions.
Thanks, I'll ask the author to include a statement.

> --
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
https://krosos.org/~/ng0/ https://www.infotropique.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-18 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170214185339.25538-1-contact.ng0@cryptolab.net>
     [not found] ` <20170214185339.25538-2-contact.ng0@cryptolab.net>
     [not found]   ` <871suvu8yu.fsf@elephly.net>
2017-04-15 15:28     ` bug#25728: [PATCH 2/2] gnu: Add colorforth ng0
2017-04-15 16:00       ` ng0
2017-06-18 10:59         ` [bug#25728] " Ricardo Wurmus
2017-06-18 11:59           ` ng0 [this message]
2017-06-18 13:52             ` Ricardo Wurmus
2017-06-28  9:48               ` ng0
2017-07-17 20:36                 ` Ricardo Wurmus
2017-07-17 20:43                   ` Ricardo Wurmus
2017-07-17 20:46                     ` Ricardo Wurmus
2017-07-17 21:58                       ` ng0
2017-07-23  8:35                       ` ng0
2017-08-10  8:04                         ` Konstantin Tcholokachvili
2017-10-10 13:13                           ` ng0
2017-10-11 10:45                             ` bug#25728: " ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170618115947.jo22jym5bm6semng@abyayala \
    --to=ng0@infotropique.org \
    --cc=25728@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).