* bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
@ 2017-06-03 23:54 Leo Famulari
2017-06-06 23:12 ` Ludovic Courtès
2017-06-07 9:56 ` Alex Kost
0 siblings, 2 replies; 4+ messages in thread
From: Leo Famulari @ 2017-06-03 23:54 UTC (permalink / raw)
To: 27225
* gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
use the full commit hash when fetching.
---
gnu/artwork.scm | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/gnu/artwork.scm b/gnu/artwork.scm
index 94c89143a..204845bd6 100644
--- a/gnu/artwork.scm
+++ b/gnu/artwork.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -28,13 +29,15 @@
;;; Code:
(define %artwork-repository
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
- (commit "6998d30")))
- (sha256
- (base32
- "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
+ (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
+ (commit commit)))
+ (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
+ (sha256
+ (base32
+ "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
;;; artwork.scm ends here
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
2017-06-03 23:54 bug#27225: [PATCH] artwork: Use a descriptive name for the source directory Leo Famulari
@ 2017-06-06 23:12 ` Ludovic Courtès
2017-06-07 9:56 ` Alex Kost
1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2017-06-06 23:12 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27225
Leo Famulari <leo@famulari.name> skribis:
> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
Good idea, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
2017-06-03 23:54 bug#27225: [PATCH] artwork: Use a descriptive name for the source directory Leo Famulari
2017-06-06 23:12 ` Ludovic Courtès
@ 2017-06-07 9:56 ` Alex Kost
2017-06-07 19:59 ` Leo Famulari
1 sibling, 1 reply; 4+ messages in thread
From: Alex Kost @ 2017-06-07 9:56 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27225
Leo Famulari (2017-06-03 19:54 -0400) wrote:
> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
> gnu/artwork.scm | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -28,13 +29,15 @@
> ;;; Code:
>
> (define %artwork-repository
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> - (commit "6998d30")))
> - (sha256
> - (base32
> - "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> + (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> + (commit commit)))
> + (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
As for me, this line is too long, I would make it:
(file-name (string-append "guix-artwork-" (string-take commit 7)
"-checkout"))
> + (sha256
> + (base32
> + "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>
> ;;; artwork.scm ends here
--
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#27225: [PATCH] artwork: Use a descriptive name for the source directory.
2017-06-07 9:56 ` Alex Kost
@ 2017-06-07 19:59 ` Leo Famulari
0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2017-06-07 19:59 UTC (permalink / raw)
To: Alex Kost; +Cc: 27225-done
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Wed, Jun 07, 2017 at 12:56:56PM +0300, Alex Kost wrote:
> Leo Famulari (2017-06-03 19:54 -0400) wrote:
> > * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> > use the full commit hash when fetching.
> > + (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
>
> As for me, this line is too long, I would make it:
>
> (file-name (string-append "guix-artwork-" (string-take commit 7)
> "-checkout"))
Oops! Fixed before pushing as 94db92f78ec9c849f9c8da05d4d35356909f9fbe.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-07 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-03 23:54 bug#27225: [PATCH] artwork: Use a descriptive name for the source directory Leo Famulari
2017-06-06 23:12 ` Ludovic Courtès
2017-06-07 9:56 ` Alex Kost
2017-06-07 19:59 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).