unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27220@debbugs.gnu.org
Subject: bug#27220: [PATCH 3/3] gnu: openldap: Provide path to cyrus-sasl for	libtool.
Date: Sun, 4 Jun 2017 12:44:50 -0400	[thread overview]
Message-ID: <20170604164450.GF14880@jasmine> (raw)
In-Reply-To: <87shjfyisq.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

On Sun, Jun 04, 2017 at 03:38:29PM +0200, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > * gnu/packages/openldap.scm (openldap)[arguments]: Add 'patch-sasl-path' phase..

> > +        (add-after 'install 'patch-sasl-path
> > +          ;; Give -L arguments for cyrus-sasl to avoid propagation.
> > +          (lambda* (#:key inputs outputs #:allow-other-keys)
> > +            (let ((out (assoc-ref outputs "out"))
> > +                  (sasl (assoc-ref inputs "cyrus-sasl")))
> > +              (substitute* (map (lambda (f) (string-append out "/" f))
> > +                                '("lib/libldap.la" "lib/libldap_r.la"))
> > +                (("-lsasl2" lib)
> > +                 (string-append "-L" sasl "/lib " lib)))
> > +              #t))))))
> 
> Good find. LGTM, but I wonder if it would be better to remove the static
> library (and associated .la files) and instead provide an explicit
> static-package. This mostly for grafting purposes.

True. I found this while trying to build the latest ncmpcpp, which added a
dependency on curl, which depends on openldap. I copied the solution from the
hwloc package in (gnu packages mpi).

> However, I think that's a journey for another core-updates.

Yes :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-04 16:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 21:28 bug#27220: OpenLDAP changes for core-updates Leo Famulari
2017-06-03 21:30 ` bug#27220: [PATCH 1/3] gnu: openldap: Update to 2.4.45 Leo Famulari
2017-06-03 21:30   ` bug#27220: [PATCH 2/3] gnu: openldap: Use modify-phases Leo Famulari
2017-06-04 13:33     ` Marius Bakke
2017-06-04 16:39       ` Leo Famulari
2017-06-03 21:30   ` bug#27220: [PATCH 3/3] gnu: openldap: Provide path to cyrus-sasl for libtool Leo Famulari
2017-06-04 13:38     ` Marius Bakke
2017-06-04 16:44       ` Leo Famulari [this message]
2017-06-04 13:33   ` bug#27220: [PATCH 1/3] gnu: openldap: Update to 2.4.45 Marius Bakke
2017-06-04 16:37     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170604164450.GF14880@jasmine \
    --to=leo@famulari.name \
    --cc=27220@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).