From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27071@debbugs.gnu.org
Subject: bug#27071: [PATCH 3/3] gnu: Add python-flasgger.
Date: Sat, 27 May 2017 15:54:46 +0200 [thread overview]
Message-ID: <20170527155446.1b8c0f14@scratchpost.org> (raw)
In-Reply-To: <87fufsvjyi.fsf@fastmail.com>
Hi Marius,
thanks for the review.
On Thu, 25 May 2017 21:02:13 +0200
Marius Bakke <mbakke@fastmail.com> wrote:
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
> > * gnu/packages/python.scm (python-flasgger,
> > python2-flasgger): New variables.
>
> [...]
>
> > + (build-system python-build-system)
> > + (arguments
> > + `(#:tests? #f))
>
> Please add a comment about why tests are disabled.
Because they don't work. I've reported it upstream at <https://github.com/rochacbruno/flasgger/issues/105>.
> Especially since
> pytest is a native-input. Should it be?
I guess not with tests disabled.
I'll keep trying to get it to work including the tests, but so far that requires the following new packages we didn't have:
- python-jsonpointer
- python-rfc3987
- python-validate-email
- python-flex
It also requires new native-inputs, finally ending up with:
(define-public python-flasgger
(package
(name "python-flasgger")
(version "0.6.3")
(source
(origin
(method url-fetch)
(uri (string-append "https://github.com/rochacbruno/flasgger/archive/"
version ".tar.gz"))
(file-name (string-append name "-" version ".tar.gz"))
(sha256
(base32
"1gqzlm0rb55fdpsy5ipkganlx9cnpi454fqyycr03jm22zql14ay"))))
(build-system python-build-system)
(arguments
`(#:phases
(modify-phases %standard-phases
(replace 'check
(lambda* (#:key inputs outputs #:allow-other-keys)
(substitute* "Makefile"
(("flake8 flasgger --ignore=F403")
"flake8 flasgger --ignore=E731,F403"))
(setenv "PYTHONPATH" (string-append (getcwd)
":"
(getenv "PYTHONPATH")))
;(zero? (system* "py.test"))
(zero? (system* "make" "test"))
;#t
)))))
(propagated-inputs
`(("python-flask" ,python-flask)
("python-pyyaml" ,python-pyyaml)
("python-jsonschema" ,python-jsonschema)
("python-mistune" ,python-mistune)
("python-six" ,python-six)))
(native-inputs
`(("python-decorator" ,python-decorator)
("python-flake8" ,python-flake8)
("python-flask-restful" ,python-flask-restful)
("python-flex" ,python-flex)
("python-pytest-3.0" ,python-pytest-3.0)
("python-pytest-cov" ,python-pytest-cov)))
(home-page "https://github.com/rochacbruno/flasgger/")
(synopsis "Extract Swagger specs from your Flask project")
(description "This package allows extracting Swagger specs from your Flask
project. It is a fork of Flask-Swagger.")
(license license:expat)))
And then the tests finally run and fail.
Let's wait for a few days whether there's an easy fix from upstream. If not, we can still commit it with the tests disabled (ugh).
next prev parent reply other threads:[~2017-05-27 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 17:51 bug#27071: [PATCH 0/3] Add flask-script, flask-migrate, flasgger Danny Milosavljevic
2017-05-25 17:57 ` bug#27071: [PATCH 1/3] gnu: Add python-flask-script Danny Milosavljevic
2017-05-25 17:57 ` bug#27071: [PATCH 2/3] gnu: Add python-flask-migrate Danny Milosavljevic
2017-05-25 19:00 ` Marius Bakke
2017-05-25 17:57 ` bug#27071: [PATCH 3/3] gnu: Add python-flasgger Danny Milosavljevic
2017-05-25 19:02 ` Marius Bakke
2017-05-27 13:54 ` Danny Milosavljevic [this message]
2017-06-03 6:22 ` bug#27071: [PATCH v2 0/8] Add python-flasgger and its dependencies Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 1/8] gnu: Add python-jsonpointer Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 2/8] gnu: Add python-rfc3987 Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 3/8] gnu: Add python-validate-email Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 4/8] gnu: Add python-flex Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 5/8] gnu: Add python-marshmallow Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 6/8] gnu: Add python-bottle Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 7/8] gnu: Add python-apispec Danny Milosavljevic
2017-06-03 6:22 ` bug#27071: [PATCH v2 8/8] gnu: Add python-flasgger Danny Milosavljevic
2017-06-04 12:09 ` bug#27071: [PATCH v2 0/8] Add python-flasgger and its dependencies Marius Bakke
2017-05-25 19:00 ` bug#27071: [PATCH 1/3] gnu: Add python-flask-script Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170527155446.1b8c0f14@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=27071@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).