From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCBK9-0001Od-AM for guix-patches@gnu.org; Sat, 20 May 2017 16:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCBK6-0007JF-6B for guix-patches@gnu.org; Sat, 20 May 2017 16:50:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCBK6-0007J5-3Y for guix-patches@gnu.org; Sat, 20 May 2017 16:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dCBK5-000760-K3 for guix-patches@gnu.org; Sat, 20 May 2017 16:50:01 -0400 Subject: bug#26339: [PATCH] doc: Adapt to multiple bootloader support. Resent-Message-ID: Date: Sat, 20 May 2017 22:49:26 +0200 From: Danny Milosavljevic Message-ID: <20170520224926.25c8af21@scratchpost.org> In-Reply-To: <20170516130306.10414-1-m.othacehe@gmail.com> References: <20170402134916.2871-1-m.othacehe@gmail.com> <20170516130306.10414-1-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26339@debbugs.gnu.org Hi Mathieu, On Tue, 16 May 2017 15:03:06 +0200 Mathieu Othacehe wrote: > Here's the doc patch. While writting it, I noticed that using > for 's menu-entry fields > was maybe not a good idea. >=20 > has no default values and it might be hard to understand > by final users. WDYT ? =46rom an understanding standpoint I don't think it's that bad. What worries me more is that now AND BEFORE, you can't boot anything other = than Linux, no bootsector chainloading or anything. I'm not sure what the use case that "menu-entries" is trying to address is,= then. I mean both the current generation and previous generations are aut= omatically there and you can't specify any menu-entries but Linux, so what = are you gonna specify? Also, already allows overriding = kernel-arguments, too. Luckily, Tom=C3=A1=C5=A1 =C4=8Cech just noticed that "menu-entries" changed= , so presumably he uses it. Will ask what use case he has... > +(boot-parameters > (label "The Other Distro") > - (linux "/boot/old/vmlinux-2.6.32") > - (linux-arguments '("root=3D/dev/sda2")) > + (root-device "my-root") > + (boot-name 'grub) > + (store-device "my-root") > + (store-mount-point "/") > + (kernel "/boot/old/vmlinux-2.6.32") > + (kernel-arguments '("root=3D/dev/sda2")) > (initrd "/boot/old/initrd")) > @end example This here isn't so bad. > +@item @code{root-device} > +The root device identifier. It has to correspond exactly to the device > +field of the object representing the OS's root file > +system, so it might be a device path like @code{"/dev/sda3"}. > + > +@item @code{boot-device} Did you mean "boot-name" ? > +The name of the bootloader used to boot this entry (@code{'grub} or > +@code{'syslinux} for instance). This one is a strange implementation detail to expose for menu entries, tho= ugh. Maybe have operating-system-bootcfg magically complete it if it's uns= et? Then add here "If in doubt, don't specify it.". > +@item @code{store-device} > +The device where the kernel and initrd are to be found---i.e., for GRUB > +@dfn{root} for this menu entry (@pxref{root,,, grub, GNU GRUB manual}). > + > +Depending on the bootloader, this may be a file system label (a > +string), a file system UUID (a bytevector, @pxref{File Systems}), or > +@code{#f}. If set to @code{#f}, GRUB will search the device containing > +the file specified by the @code{linux} field (@pxref{search,,, grub, > +GNU GRUB manual}). It must @emph{not} be an OS device name such as > +@file{/dev/sda1}. Maybe default to #f in in gnu/system.scm ? Then add here "If in doubt, don't specify it.". > +@item @code{store-mount-point} > +The mount point of the above device on the system. You probably want > +to set it to @code{"/"}. GuixSD uses it to strip the prefix of store > +file names for systems where @file{/gnu} or @file{/gnu/store} is on a > +separate partition. Maybe default to "/" in