unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26875@debbugs.gnu.org
Subject: bug#26875: [v2] system: grub: Expose GRUB's interactive interface settings.
Date: Sat, 13 May 2017 12:40:32 -0400	[thread overview]
Message-ID: <20170513164032.GA4286@jasmine> (raw)
In-Reply-To: <871srs50gw.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

On Sat, May 13, 2017 at 03:51:27PM +0200, Ludovic Courtès wrote:
> > +@item @code{terminal-outputs} (default: @code{'gfxterm})
> > +The output terminals used for the GRUB boot menu, as a list of symbols.
> > +These values are accepted: console, serial, serial_@{0-3@}, gfxterm,
> > +vga_text, mda_text, morse, spkmodem
> 
> Please use @code for the possible, add a final period, and a
> cross-reference to the relevant part of the GRUB manual with
> “(@pxref{…})” if possible.

Okay!

> 
> > +@item @code{terminal-inputs} (default: @code{'()})
> > +The input terminals used for the GRUB boot menu, as a list of symbols.
> > +The default is the native platform terminal as determined by GRUB at
> > +run-time.  These values are accepted: console, serial, serial_@{0-3@},
> > +at_keyboard, usb_keyboard.
> > +
> > +@item @code{serial-unit} (default: @code{#f})
> > +The serial unit used by GRUB, as an integer from 0 to 3.  The default
> > +value is chosen by GRUB at run-time; currently GRUB chooses 0, which
> > +corresponds to COM1.
> 
> Likewise.

Yes!

> 
> > +@item @code{serial-speed} (default: @code{#f})
> > +The speed of the serial interface, as an integer.  The default value is
> > +chosen by GRUB at run-time; currently GRUB chooses 9600bps.
> 
> 9,600@tie{}bps.  :-)

Sure!

> Apart from that, as long as “make check-system TESTS=basic” and similar
> pass, that’s all good for me!

I tried the basic, btrfs-root-os, and encrypted-root-os tests. Testers
should note this is an ABI break.

> Mathieu: is it OK to apply this before the patch series on non-GRUB
> bootloaders?

I'll wait for this response.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-13 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  7:36 bug#26875: Non-graphical (and other types) of GRUB interfaces Leo Famulari
2017-05-11  7:46 ` ng0
2017-05-13  5:15   ` Leo Famulari
2017-05-13  5:21 ` bug#26875: [v2] system: grub: Expose GRUB's interactive interface settings Leo Famulari
2017-05-13 13:51   ` Ludovic Courtès
2017-05-13 16:40     ` Leo Famulari [this message]
2017-05-14  7:38     ` Mathieu Othacehe
2017-05-14 18:17       ` Leo Famulari
2017-05-15  9:36 ` bug#26875: Non-graphical (and other types) of GRUB interfaces Brendan Tildesley
2017-05-15 18:04   ` Leo Famulari
2017-05-15 20:25   ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170513164032.GA4286@jasmine \
    --to=leo@famulari.name \
    --cc=26875@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).