unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ethan R. Jones" <doubleplusgood23@gmail.com>
Cc: 26872@debbugs.gnu.org
Subject: bug#26872: [PATCH 1/4] gnu: libpwquality: fix source URL.
Date: Wed, 10 May 2017 23:48:56 -0400	[thread overview]
Message-ID: <20170511034856.GA4088@jasmine> (raw)
In-Reply-To: <20170511024140.1852-1-doubleplusgood23@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On Wed, May 10, 2017 at 10:41:37PM -0400, Ethan R. Jones wrote:

Thanks! Pushed as c18594dd95f98624b09b51ef5f8aea0a0d4d1743 with the
following cosmetic changes:

First, I filled out all the details in the commit message so it meets
our conventions:

    gnu: libpwquality: Update source and home-page URLs.
    
    * gnu/packages/password-utils.scm (libpwquality)[source]: Update URL.
    [home-page]: Update URL.
    
    Signed-off-by: Leo Famulari <leo@famulari.name>

This "ChangeLog" format is mentioned in the Guix manual under
'Submitting Patches'. I usually read older, similar commits when I'm
unsure.

>                (uri (list
> -                    (string-append "https://fedorahosted.org/releases/l/i/"
> -                                   name "/" name "-" version ".tar.bz2")
> +                    (string-append "https://github.com/"
> +                                   name
> +                                   "/"
> +                                   name
> +                                   "/releases/download/"
> +                                   name  "-" version
> +                                   "/"
> +                                   name "-" version ".tar.bz2")

I collapsed this to use fewer lines.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2017-05-11  3:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  2:41 bug#26872: [PATCH 1/4] gnu: libpwquality: fix source URL Ethan R. Jones
2017-05-11  2:41 ` bug#26873: [PATCH 2/4] gnu: font-liberation: fix source and homepage URL Ethan R. Jones
2017-05-11  3:49   ` Leo Famulari
2017-05-11  2:41 ` bug#26872: [PATCH 3/4] gnu: python2-dogtail: fix homepage URL python-kitchen: fix " Ethan R. Jones
2017-05-11  3:51   ` Leo Famulari
2017-05-11  2:41 ` bug#26872: [PATCH 4/4] gnu: libaio: fix source URL Ethan R. Jones
2017-05-11  3:50   ` Leo Famulari
2017-05-11  3:48 ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170511034856.GA4088@jasmine \
    --to=leo@famulari.name \
    --cc=26872@debbugs.gnu.org \
    --cc=doubleplusgood23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).