From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8YRv-0005nz-GZ for guix-patches@gnu.org; Wed, 10 May 2017 16:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8YRq-0004P3-Kx for guix-patches@gnu.org; Wed, 10 May 2017 16:43:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34539) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8YRq-0004Os-HA for guix-patches@gnu.org; Wed, 10 May 2017 16:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8YRp-0005XG-LU for guix-patches@gnu.org; Wed, 10 May 2017 16:43:01 -0400 Subject: bug#26805: [PATCH] gs-fonts: add missing podule imports Resent-Message-ID: Date: Wed, 10 May 2017 21:41:41 +0100 From: Sergei Trofimovich Message-ID: <20170510214141.60fe16d4@sf> In-Reply-To: <877f1pvsfu.fsf@gnu.org> References: <20170506154035.23664-1-slyfox@inbox.ru> <87pofi8h6p.fsf@gnu.org> <20170509213630.7c81b553@sf> <877f1pvsfu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/Mo=he+afEy=LG0kimpvsuAm"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26805@debbugs.gnu.org --Sig_/Mo=he+afEy=LG0kimpvsuAm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 10 May 2017 13:53:41 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > What about adding (srfi srfi-1) to =E2=80=98%default-modules=E2=80=99 in = (guix > build-system gnu)? It=E2=80=99s generally useful anyway. >=20 > (Alternately, we could rename SRFI-1=E2=80=99s =E2=80=98delete=E2=80=99 i= n (guix build utils), > so we=E2=80=99d still be matching a literal, but we=E2=80=99d have proble= ms in places > that use both (guix build utils) and (srfi srfi-1).) I'd personally say the less magic reexports - the better. It's ok to go through all of core-updates and fix missing imports. Would be nice the all those syntactic errors could be caught with something lighter-weight than full 'guix build'. I'm afraid I have no idea how symbol visibility works in guix as I'm still struggling to find which code builds and evaluates '*-guile-builder' = files. For example what is the difference between (use-modules .... and (arguments '(#:modules ? Should be one preferred over another? The latter creeps in core-updates :) https://git.savannah.gnu.org/cgit/guix.git/log/?h=3Dcore-updates A few recent examples: https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dcore-updates&id= =3Da8f25449114bd9035898eec3455db51c0f4d928d https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dcore-updates&id= =3Dbc81e6cae40098684c14b10d0aa4c6257acbbdb6 https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dcore-updates&id= =3D47babd445a9f0e6fe9356cbe362d390f09df4e3b etc. --=20 Sergei --Sig_/Mo=he+afEy=LG0kimpvsuAm Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSZKa0VG5avZRlY01hxoe52YR/zqgUCWRN7BwAKCRBxoe52YR/z qtR8AJwPP2TQi/gvb0Twt7gVPwVXDmYrYQCdGlqn+tD3byq6iOkhH7oj6puwP5k= =3q5k -----END PGP SIGNATURE----- --Sig_/Mo=he+afEy=LG0kimpvsuAm--