unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergei Trofimovich <slyfox@inbox.ru>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26805@debbugs.gnu.org
Subject: bug#26805: [PATCH] gs-fonts: add missing podule imports
Date: Wed, 10 May 2017 21:41:41 +0100	[thread overview]
Message-ID: <20170510214141.60fe16d4@sf> (raw)
In-Reply-To: <877f1pvsfu.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Wed, 10 May 2017 13:53:41 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> What about adding (srfi srfi-1) to ‘%default-modules’ in (guix
> build-system gnu)?  It’s generally useful anyway.
> 
> (Alternately, we could rename SRFI-1’s ‘delete’ in (guix build utils),
> so we’d still be matching a literal, but we’d have problems in places
> that use both (guix build utils) and (srfi srfi-1).)

I'd personally say the less magic reexports - the better. It's ok to go
through all of core-updates and fix missing imports.

Would be nice the all those syntactic errors could be caught with something
lighter-weight than full 'guix build'.

I'm afraid I have no idea how symbol visibility works in guix as I'm
still struggling to find which code builds and evaluates '*-guile-builder' files.

For example what is the difference between
    (use-modules ....
and
    (arguments '(#:modules
?

Should be one preferred over another? The latter creeps in core-updates :)
    https://git.savannah.gnu.org/cgit/guix.git/log/?h=core-updates

A few recent examples:
    https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=a8f25449114bd9035898eec3455db51c0f4d928d
    https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=bc81e6cae40098684c14b10d0aa4c6257acbbdb6
    https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=47babd445a9f0e6fe9356cbe362d390f09df4e3b
etc.

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2017-05-10 20:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 15:40 bug#26805: [PATCH] gs-fonts: add missing podule imports Sergei Trofimovich
2017-05-07 19:06 ` bug#26805: [PATCH] gs-fonts: add missing module imports Danny Milosavljevic
2017-05-09 10:20 ` bug#26805: [PATCH] gs-fonts: add missing podule imports Ludovic Courtès
2017-05-09 20:36   ` Sergei Trofimovich
2017-05-10 11:53     ` Ludovic Courtès
2017-05-10 20:41       ` Sergei Trofimovich [this message]
2017-05-11 20:49         ` Ludovic Courtès
2017-05-14 16:31           ` Sergei Trofimovich
2017-05-14 20:02             ` Ludovic Courtès
2017-05-14 23:15               ` Sergei Trofimovich
2017-05-26 13:02                 ` bug#26805: Re-exporting ‘delete’ from (guix build utils) Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170510214141.60fe16d4@sf \
    --to=slyfox@inbox.ru \
    --cc=26805@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).