bug#26819: [PATCH] gnu: Add f3.

bug#26819: [PATCH] gnu: Add f3.

[Hartmut Goebel]

* gnu/packages/disk.scm (f3): New variable.
---
 gnu/packages/disk.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 9389527..2889509 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -337,3 +337,44 @@ project to detect and manipulate partition tables.  Optional file system tools
 permit managing file systems not included in libparted.")
     ;; The home page says GPLv2, but the source code says GPLv2+.
     (license license:gpl2+)))
+
+
+(define-public f3
+  (package
+    (name "f3")
+    (version "6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "https://github.com/AltraMayor/f3/archive/"
+                          "v" version ".tar.gz"))
+      (file-name (string-append name "-" version ".tar.gz"))
+      (sha256
+       (base32
+        "1mgbzc1swvgil45md1336j0aqkmkhwmpxical0ln5g09b2qxsanp"))))
+    (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f ; no check target
+      #:make-flags (list "CC=gcc"
+                         (string-append "PREFIX=" %output))
+      #:phases
+      (modify-phases %standard-phases
+        (delete 'configure)
+        (add-before 'build 'fix-makefile
+          (lambda _
+            (substitute* "Makefile"
+              ((" -oroot -groot ") " ")
+              ;; also build and install experimental tools
+              (("^all: ") "all: $(EXPERIMENTAL_TARGETS) ")
+              (("^install: ") "install-all: ")
+              (("^install-experimental: ") "install: install-all ")))))))
+   (inputs
+    `(("eudev" ,eudev)
+      ("parted" ,parted)))
+    (home-page "http://oss.digirati.com.br/f3/")
+    (synopsis "Test real capacity of flash memory cards and such.")
+    (description "F3 (Fight Flash Fraud or Fight Fake Flash) tests the full
+capacity of a flash card (flash drive, flash disk, pendrive).  F3 writes to
+the card and then checks if can read it.  It will assure you haven't been sold
+a card with a smaller capacity than stated.")
+    (license license:gpl3)))
-- 
2.7.4

bug#26819: [PATCH] gnu: Add f3.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

On Sun, May 07, 2017 at 08:46:12PM +0200, Hartmut Goebel wrote:
> * gnu/packages/disk.scm (f3): New variable.

Thanks! LGTM overall...

> +              ((" -oroot -groot ") " ")

Can you add a comment explaining this one?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26819: [PATCH] gnu: Add f3.

[Hartmut Goebel]

Made teh requested changed and pushed as
49393691d75a3334d3abb8e54f4e08ce47734f03

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

bug#26819: [PATCH] gnu: Add f3.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2515 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/disk.scm (f3): New variable.
> ---
>  gnu/packages/disk.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
> index 9389527..2889509 100644
> --- a/gnu/packages/disk.scm
> +++ b/gnu/packages/disk.scm
> @@ -337,3 +337,44 @@ project to detect and manipulate partition tables.  Optional file system tools
>  permit managing file systems not included in libparted.")
>      ;; The home page says GPLv2, but the source code says GPLv2+.
>      (license license:gpl2+)))
> +
> +
> +(define-public f3
> +  (package
> +    (name "f3")
> +    (version "6.0")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "https://github.com/AltraMayor/f3/archive/"
> +                          "v" version ".tar.gz"))
> +      (file-name (string-append name "-" version ".tar.gz"))
> +      (sha256
> +       (base32
> +        "1mgbzc1swvgil45md1336j0aqkmkhwmpxical0ln5g09b2qxsanp"))))
> +    (build-system gnu-build-system)
> +   (arguments

Indentation is off here.

> +    '(#:tests? #f ; no check target
> +      #:make-flags (list "CC=gcc"
> +                         (string-append "PREFIX=" %output))
> +      #:phases
> +      (modify-phases %standard-phases
> +        (delete 'configure)
> +        (add-before 'build 'fix-makefile
> +          (lambda _
> +            (substitute* "Makefile"
> +              ((" -oroot -groot ") " ")
> +              ;; also build and install experimental tools
> +              (("^all: ") "all: $(EXPERIMENTAL_TARGETS) ")
> +              (("^install: ") "install-all: ")
> +              (("^install-experimental: ") "install: install-all ")))))))

Make sure this phase returns a #t.

> +   (inputs
> +    `(("eudev" ,eudev)
> +      ("parted" ,parted)))
> +    (home-page "http://oss.digirati.com.br/f3/")
> +    (synopsis "Test real capacity of flash memory cards and such.")
> +    (description "F3 (Fight Flash Fraud or Fight Fake Flash) tests the full
> +capacity of a flash card (flash drive, flash disk, pendrive).  F3 writes to
> +the card and then checks if can read it.  It will assure you haven't been sold
> +a card with a smaller capacity than stated.")
> +    (license license:gpl3)))

I can't find any license version information in the source code. Unless
a version is explicitly mentioned in the source header, we default to
"or later".

Other than that LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]