From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7TQR-0000Lp-3Z
	for guix-patches@gnu.org; Sun, 07 May 2017 17:09:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7TQM-0000ts-13
	for guix-patches@gnu.org; Sun, 07 May 2017 17:09:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34410)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7TQL-0000to-U3
	for guix-patches@gnu.org; Sun, 07 May 2017 17:09:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7TQL-0005FX-Og
	for guix-patches@gnu.org; Sun, 07 May 2017 17:09:01 -0400
Subject: bug#26339: [PATCH v3 7/9] scripts: system: Adapt "init" to new
	bootloader API.
Resent-Message-ID: <handler.26339.B26339.149419131320145@debbugs.gnu.org>
Date: Sun, 7 May 2017 23:08:29 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170507230829.22f0ce70@scratchpost.org>
In-Reply-To: <20170506154154.17836-8-m.othacehe@gmail.com>
References: <20170506154154.17836-1-m.othacehe@gmail.com>
	<20170506154154.17836-8-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

On Sat,  6 May 2017 17:41:52 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> --- a/guix/scripts/system.scm
> +++ b/guix/scripts/system.scm
> @@ -178,12 +178,14 @@ TARGET, and register them."
>  
>  (define* (install os-drv target
>                    #:key (log-port (current-output-port))
> -                  grub? grub.cfg device)
> -  "Copy the closure of GRUB.CFG, which includes the output of OS-DRV, to
> +                  installer install-bootloader?

"bootloader-installer.drv" instead of "installer"?

>[reinstall-bootloader]
> -       (install-proc
> +       (installer
>          (let ((procedure (bootloader-configuration-installer
>                            (operating-system-bootloader os)))
>                (target    (or target "/")))

"installer.drv" instead of "installer", and "installer" instead of "procedure".  Also, deja vu.  Patch 6/9 also includes something of this part.

Otherwise LGTM!