From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: 26788@debbugs.gnu.org, Ricardo Wurmus <rekado@elephly.net>
Subject: bug#26788: [PATCH] gnu: nfs-utils: Update to 2.1.1.
Date: Sun, 7 May 2017 16:48:40 -0400 [thread overview]
Message-ID: <20170507204840.GA3936@jasmine> (raw)
In-Reply-To: <87bmr5hprl.fsf@openmailbox.org>
[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]
On Sat, May 06, 2017 at 01:13:50PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
>
> > * gnu/packages/nfs.scm (nfs-utils): Update to 2.1.1.
>
> LGTM.
Thanks!
I poked around some more and found that our nfs-utils package does not
keep a reference to gss. So, I'm removing gss in this update.
I also verified that all of the substitutions in the
'adjust-command-file-names' phase still have an effect.
I'll push these updated patches soon if there are no more comments.
[-- Attachment #1.2: 0001-gnu-nfs-utils-Update-to-2.1.1.patch --]
[-- Type: text/plain, Size: 1923 bytes --]
From 633f9ba6139d6a721d47b1662a72c0efbae95268 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Thu, 4 May 2017 21:17:07 -0400
Subject: [PATCH 1/2] gnu: nfs-utils: Update to 2.1.1.
* gnu/packages/nfs.scm (nfs-utils): Update to 2.1.1.
[inputs]: Remove gss.
---
gnu/packages/nfs.scm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/nfs.scm b/gnu/packages/nfs.scm
index f18fe6cb5..03ac841e4 100644
--- a/gnu/packages/nfs.scm
+++ b/gnu/packages/nfs.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2016 John Darrington <jmd@gnu.org>
+;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -20,7 +21,6 @@
#:use-module (gnu packages)
#:use-module (gnu packages linux)
#:use-module (gnu packages databases)
- #:use-module (gnu packages gsasl)
#:use-module (gnu packages libevent)
#:use-module (gnu packages kerberos)
#:use-module (gnu packages onc-rpc)
@@ -41,7 +41,7 @@
(define-public nfs-utils
(package
(name "nfs-utils")
- (version "1.3.4")
+ (version "2.1.1")
(source (origin
(method url-fetch)
(uri (string-append
@@ -49,7 +49,7 @@
"/nfs-utils-" version ".tar.xz"))
(sha256
(base32
- "0xarqhwy757vazv9gqhyrgxsrx083yhvkkih01jh83fqm305naml"))))
+ "1vqrqzhg9nh2wj1icp7k8v9dibgnn521b45np79nnkmqf16bbbhg"))))
(build-system gnu-build-system)
(arguments
`(#:configure-flags
@@ -98,7 +98,6 @@
("libnfsidmap" ,libnfsidmap)
("sqlite" ,sqlite)
("lvm2" ,lvm2)
- ("gss" ,gss)
("util-linux" ,util-linux)
("mit-krb5" ,mit-krb5)
("libtirpc" ,libtirpc)))
--
2.12.2
[-- Attachment #1.3: 0002-gnu-nfs-utils-Adjust-indentation.patch --]
[-- Type: text/plain, Size: 4495 bytes --]
From b39ebdb434140ae654199ca6df0d35b5aa8fe4ca Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Sun, 7 May 2017 16:33:06 -0400
Subject: [PATCH 2/2] gnu: nfs-utils: Adjust indentation.
* gnu/packages/nfs.scm (nfs-utils): Re-indent.
---
gnu/packages/nfs.scm | 70 ++++++++++++++++++++++++++--------------------------
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/gnu/packages/nfs.scm b/gnu/packages/nfs.scm
index 03ac841e4..28751c400 100644
--- a/gnu/packages/nfs.scm
+++ b/gnu/packages/nfs.scm
@@ -57,43 +57,43 @@
,(string-append "--with-start-statd="
(assoc-ref %outputs "out") "/sbin/start-statd")
,(string-append "--with-krb5=" (assoc-ref %build-inputs "mit-krb5")))
- #:phases (modify-phases %standard-phases
- (add-before
- 'configure 'adjust-command-file-names
- (lambda _
- ;; Remove assumptions of FHS from start-statd script
- (substitute* `("utils/statd/start-statd")
- (("^PATH=.*") "")
- (("^flock")
- (string-append
- (assoc-ref %build-inputs "util-linux")
- "/bin/flock"))
- (("^exec rpc.statd")
- (string-append "exec "
- (assoc-ref %outputs "out") "/sbin/rpc.statd")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'configure 'adjust-command-file-names
+ (lambda _
+ ;; Remove assumptions of FHS from start-statd script
+ (substitute* `("utils/statd/start-statd")
+ (("^PATH=.*") "")
+ (("^flock")
+ (string-append
+ (assoc-ref %build-inputs "util-linux")
+ "/bin/flock"))
+ (("^exec rpc.statd")
+ (string-append "exec "
+ (assoc-ref %outputs "out") "/sbin/rpc.statd")))
- ;; This hook tries to write to /var
- ;; That needs to be done by a service too.
- (substitute* `("Makefile.in")
- (("^install-data-hook:")
- "install-data-hook-disabled-for-guix:"))
+ ;; This hook tries to write to /var
+ ;; That needs to be done by a service too.
+ (substitute* `("Makefile.in")
+ (("^install-data-hook:")
+ "install-data-hook-disabled-for-guix:"))
- ;; Replace some hard coded paths.
- (substitute* `("utils/nfsd/nfssvc.c")
- (("/bin/mount")
- (string-append
- (assoc-ref %build-inputs "util-linux")
- "/bin/mount")))
- (substitute* `("utils/statd/statd.c")
- (("/usr/sbin/")
- (string-append (assoc-ref %outputs "out") "/sbin/")))
- (substitute* `("utils/osd_login/Makefile.in"
- "utils/mount/Makefile.in"
- "utils/nfsdcltrack/Makefile.in")
- (("^sbindir = /sbin")
- (string-append "sbindir = "
- (assoc-ref %outputs "out") "/sbin")))
- #t)))))
+ ;; Replace some hard coded paths.
+ (substitute* `("utils/nfsd/nfssvc.c")
+ (("/bin/mount")
+ (string-append
+ (assoc-ref %build-inputs "util-linux")
+ "/bin/mount")))
+ (substitute* `("utils/statd/statd.c")
+ (("/usr/sbin/")
+ (string-append (assoc-ref %outputs "out") "/sbin/")))
+ (substitute* `("utils/osd_login/Makefile.in"
+ "utils/mount/Makefile.in"
+ "utils/nfsdcltrack/Makefile.in")
+ (("^sbindir = /sbin")
+ (string-append "sbindir = "
+ (assoc-ref %outputs "out") "/sbin")))
+ #t)))))
(inputs `(("libevent" ,libevent)
("libnfsidmap" ,libnfsidmap)
("sqlite" ,sqlite)
--
2.12.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-07 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 19:35 bug#26788: [PATCH] gnu: nfs-utils: Update to 2.1.1 Leo Famulari
2017-05-06 17:13 ` Kei Kebreau
2017-05-07 20:48 ` Leo Famulari [this message]
2017-05-08 21:36 ` Kei Kebreau
2017-05-08 23:28 ` Leo Famulari
2017-05-09 5:49 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170507204840.GA3936@jasmine \
--to=leo@famulari.name \
--cc=26788@debbugs.gnu.org \
--cc=kei@openmailbox.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).