From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7PG1-00065P-S0
	for guix-patches@gnu.org; Sun, 07 May 2017 12:42:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7PFy-0001R6-Pv
	for guix-patches@gnu.org; Sun, 07 May 2017 12:42:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34108)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7PFy-0001Qy-Ml
	for guix-patches@gnu.org; Sun, 07 May 2017 12:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7PFy-0001ox-Dp
	for guix-patches@gnu.org; Sun, 07 May 2017 12:42:02 -0400
Subject: bug#26339: [PATCH v3 1/9] system: Add extlinux support.
Resent-Message-ID: <handler.26339.B26339.14941752726941@debbugs.gnu.org>
Date: Sun, 7 May 2017 18:41:05 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170507184105.5897a5c8@scratchpost.org>
In-Reply-To: <20170506154154.17836-2-m.othacehe@gmail.com>
References: <20170506154154.17836-1-m.othacehe@gmail.com>
	<20170506154154.17836-2-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

Hi Mathieu,

>guix/scripts/system.scm (profile-grub-entries): 
>Rename system->grub-entry to system->boot-parameters and adjust accordingly.

Not really - because I did this part already :)

That part of the commit message is outdated.

> +       (bootloader (let ((bootloader (bootloader-configuration-bootloader
> +                                      (operating-system-bootloader os))))
> +                     (if bootloader
> +                         (package->derivation bootloader)
> +                         (return #f))))
[...]

> +                      (if (and bootloader? bootloader)

Hmm, is it possible to (usefully) check monadic values that way?

> +          (when (and bootloader? bootloader)

Likewise.

Otherwise LGTM!