unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26813: [PATCH] re2: add missing '#:modules' imports
@ 2017-05-07 10:48 Sergei Trofimovich
  2017-05-07 18:21 ` Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Sergei Trofimovich @ 2017-05-07 10:48 UTC (permalink / raw)
  To: 26813

Noticed as a 're2' build failure:

/gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
to match any pattern in form (%modify-phases phases* (delete (quote configure)))

* gnu/packages/regex.scm (re2): add missing '#:modules' imports

Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
---
 gnu/packages/regex.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/regex.scm b/gnu/packages/regex.scm
index f55faaf04..779050525 100644
--- a/gnu/packages/regex.scm
+++ b/gnu/packages/regex.scm
@@ -41,7 +41,10 @@
                  "1s3kdcrz2mwi30k6pz9jkv5vk8b704bz65xgcr67wbn2pn3hpnqr"))))
      (build-system gnu-build-system)
      (arguments
-      `(#:test-target "test"
+      `(#:modules ((guix build gnu-build-system)
+                   (guix build utils)
+                   (srfi srfi-1))
+        #:test-target "test"
         ;; There is no configure step, but the Makefile respects a prefix.
         ;; As ./configure does not know anything about the target CXX
         ;; we need to specify TARGET-g++ explicitly.
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#26813: [PATCH] re2: add missing '#:modules' imports
  2017-05-07 10:48 bug#26813: [PATCH] re2: add missing '#:modules' imports Sergei Trofimovich
@ 2017-05-07 18:21 ` Leo Famulari
  2017-05-07 19:49   ` Sergei Trofimovich
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2017-05-07 18:21 UTC (permalink / raw)
  To: Sergei Trofimovich; +Cc: 26813-done

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

On Sun, May 07, 2017 at 11:48:37AM +0100, Sergei Trofimovich wrote:
> Noticed as a 're2' build failure:
> 
> /gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
> to match any pattern in form (%modify-phases phases* (delete (quote configure)))
> 
> * gnu/packages/regex.scm (re2): add missing '#:modules' imports
> 
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>

Pushed by Danny as 7a4a64e99e65e96a4dc3e65ae691b4c80b7642e8.

Sergei, we use the signed-off-by line to make it easier to see when
somebody has pushed a patch to Savannah on behalf of somebody else
(other projects use it in a variety of different ways). In this case,
Danny signed off on the commit for you. So, no need to sign off on your
Guix contributions :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#26813: [PATCH] re2: add missing '#:modules' imports
  2017-05-07 18:21 ` Leo Famulari
@ 2017-05-07 19:49   ` Sergei Trofimovich
  0 siblings, 0 replies; 3+ messages in thread
From: Sergei Trofimovich @ 2017-05-07 19:49 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 26813-done

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On Sun, 7 May 2017 14:21:29 -0400
Leo Famulari <leo@famulari.name> wrote:

> Sergei, we use the signed-off-by line to make it easier to see when
> somebody has pushed a patch to Savannah on behalf of somebody else
> (other projects use it in a variety of different ways). In this case,
> Danny signed off on the commit for you. So, no need to sign off on your
> Guix contributions :)

Got it. Thanks!

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-07 19:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-07 10:48 bug#26813: [PATCH] re2: add missing '#:modules' imports Sergei Trofimovich
2017-05-07 18:21 ` Leo Famulari
2017-05-07 19:49   ` Sergei Trofimovich

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).