From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59490)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7Nxh-0004rQ-Jr
	for guix-patches@gnu.org; Sun, 07 May 2017 11:19:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7Nxe-00048X-Do
	for guix-patches@gnu.org; Sun, 07 May 2017 11:19:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34046)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7Nxe-00048L-9x
	for guix-patches@gnu.org; Sun, 07 May 2017 11:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7Nxd-0008Fd-TK
	for guix-patches@gnu.org; Sun, 07 May 2017 11:19:01 -0400
Subject: bug#26815: [PATCH 3/3] vm: Support EFI boot in base image.
Resent-Message-ID: <handler.26815.B26815.149417030031669@debbugs.gnu.org>
Date: Sun, 7 May 2017 17:18:14 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170507171814.555ec8b3@scratchpost.org>
In-Reply-To: <20170507143647.21036-3-mbakke@fastmail.com>
References: <20170507143647.21036-1-mbakke@fastmail.com>
	<20170507143647.21036-3-mbakke@fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26815@debbugs.gnu.org

Hi Marius,

> +      (system* "grub-mkstandalone" "-O" "x86_64-efi" "-o"
> +               (string-append efi-directory "/EFI/BOOT/BOOTX64.EFI")
> +               ;; Embed the contents of grubdisk.cfg.
> +               (string-append "boot/grub/grub.cfg=" target
> +                              "/tmp/grubdisk.cfg"))

Check return value of system* ?

>                    (partitions (list (partition
>                                       (size #$(- disk-image-size
> -                                                (* 10 (expt 2 20))))
> +                                                (* 50 (expt 2 20))))

<https://wiki.archlinux.org/index.php/EFI_System_Partition> says:

>According to a Microsoft note[2], the minimum size for the EFI System Partition (ESP) would be 100 MB, though this is not stated in the UEFI Specification. Note that for Advanced Format 4K Native drives (4-KB-per-sector) drives, the size is at least 256 MiB, because it is the minimum partition size of FAT32 drives (calculated as sector size (4KB) x 65527 = 256 MiB), due to a limitation of the FAT32 file format. 

Is this relevant for us?

Also, <https://gist.github.com/Apsu/4108795> says that F32 is not required for most UEFI firmwares. FAT12, FAT32 usually work.  But better be safe than sorry, I guess.

> +                                     (size (* 40 (expt 2 20)))
> +                                     (label "gnu-esp")
> +                                     (file-system "vfat")

Is it really vfat with long file names and everything? Or only FAT32 (with short file names)?

I ask because a lot of UEFT file names look as if they are for FAT32 with their short all-uppercase names.