unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: 26718@debbugs.gnu.org
Subject: bug#26718: Update hexchat to 2.12.4
Date: Sun, 30 Apr 2017 21:35:44 +0200	[thread overview]
Message-ID: <20170430213539.789280bb@lepiller.eu> (raw)
In-Reply-To: <e91cf3ea-eeff-74d9-d5cd-bfab0b00016c@tobias.gr>

Le Sun, 30 Apr 2017 20:19:49 +0200,
Tobias Geerinckx-Rice <me@tobias.gr> a écrit :

> Julien,
> 
> [...]
> 
> > + (with-directory-excursion "m4"
> > +   (for-each (lambda (f) (delete-file f))
> > +             '("intltool.m4" "libtool.m4" "lt~obsolete.m4"
> > +               "ltoptions.m4" "ltsugar.m4" "ltversion.m4")))
> > + (delete-file-recursively "build-aux")
> > + (delete-file "po/Makefile.in.in")  
> 
> I'd move all of this to a separate snippet.
> These files can cause pain when building manually, too.
What's the policy about using patches, snippet or build phases? I was
recently asked to move code from snippet to build phase because it did
not address a security issue or remove non free or bundled components,
but I can't find anything documenting the choice we should make.

  reply	other threads:[~2017-04-30 19:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 17:22 bug#26718: Update hexchat to 2.12.4 Julien Lepiller
2017-04-30 18:19 ` Tobias Geerinckx-Rice
2017-04-30 19:35   ` Julien Lepiller [this message]
2017-04-30 20:05     ` Leo Famulari
2017-04-30 21:11       ` Tobias Geerinckx-Rice
2017-05-01  7:52         ` Julien Lepiller
2017-05-05 20:21           ` Leo Famulari
2017-05-06 19:55             ` Leo Famulari
2017-05-06 21:08               ` Julien Lepiller
2017-05-06 22:02                 ` Tobias Geerinckx-Rice
2017-05-06  8:22 ` bug#26718: (no subject) Julien Lepiller
2017-05-06 13:48   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170430213539.789280bb@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=26718@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).