From: ng0 <contact.ng0@cryptolab.net>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 26717@debbugs.gnu.org
Subject: bug#26717: [PATCH] gnu: gitolite: Avoid references to the store in authorized_keys.
Date: Sun, 30 Apr 2017 19:31:17 +0000 [thread overview]
Message-ID: <20170430193117.setdri6ykdbbmza3@abyayala> (raw)
In-Reply-To: <20170430163244.2830-1-clement@lassieur.org>
Clément Lassieur transcribed 1.3K bytes:
> * gnu/packages/version-control.scm (gitolite)[arguments]: Substitute
> '$glshell' with 'gitolite-shell' in ssh-authkeys.
> ---
> gnu/packages/version-control.scm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index e0770dc58..1cad0f285 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -628,7 +628,13 @@ also walk each side of a merge and test those changes individually.")
> ;; invokes Perl.
> (substitute* (find-files "." ".*")
> ((" perl -")
> - (string-append " " perl " -"))))))
> + (string-append " " perl " -")))
> +
> + ;; Avoid references to the store in authorized_keys.
> + ;; This works because gitolite-shell is in the PATH.
> + (substitute* "src/triggers/post-compile/ssh-authkeys"
> + (("\\$glshell \\$user")
> + "gitolite-shell $user")))))
> (replace 'install
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((output (assoc-ref outputs "out"))
> --
> 2.12.2
>
>
>
>
This looks good. I have yet to test it. Do you think we could fix the hook files of gitolite like this too?
--
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/
next prev parent reply other threads:[~2017-04-30 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 16:30 bug#26717: Avoid references to the store in authorized_keys Clément Lassieur
2017-04-30 16:32 ` bug#26717: [PATCH] gnu: gitolite: " Clément Lassieur
2017-04-30 19:31 ` ng0 [this message]
2017-04-30 21:57 ` Clément Lassieur
2017-05-04 8:50 ` Clément Lassieur
2017-05-03 19:47 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430193117.setdri6ykdbbmza3@abyayala \
--to=contact.ng0@cryptolab.net \
--cc=26717@debbugs.gnu.org \
--cc=clement@lassieur.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).