From: Danny Milosavljevic <dannym@scratchpost.org>
To: Thomas Danckaert <thomas.danckaert@gmail.com>
Cc: Thomas Danckaert <post@thomasdanckaert.be>, 26669@debbugs.gnu.org
Subject: bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools.
Date: Wed, 26 Apr 2017 19:15:49 +0200 [thread overview]
Message-ID: <20170426191549.6774bd32@scratchpost.org> (raw)
In-Reply-To: <20170426163038.23515-1-thomas.danckaert@gmail.com>
On Wed, 26 Apr 2017 18:30:33 +0200
Thomas Danckaert <thomas.danckaert@gmail.com> wrote:
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; We use sed --in-place because substitute* cannot handle the
> + ;; character encoding used by growisofs.c.
> + (system* "sed" "-i" "-e"
> + (string-append
> + "s,\"mkisofs\","
> + "\"" (assoc-ref inputs "cdrtools") "/bin/mkisofs\",")
> + "growisofs.c")
> + #t)))))
Maybe rather use
(zero? (system* ...))
instead of
(system* ...)
#t
Otherwise LGTM!
next prev parent reply other threads:[~2017-04-26 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 16:05 bug#26669: [PATCH 1/7] gnu: Add cdrtools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 3/7] gnu: brasero: Embed growisofs store item Thomas Danckaert
2017-04-28 5:54 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 4/7] gnu: Add dvdauthor Thomas Danckaert
2017-04-27 18:50 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 5/7] gnu: Add wxwidgets-3.1 Thomas Danckaert
2017-05-03 13:00 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 6/7] gnu: Add wxsvg Thomas Danckaert
2017-05-03 13:02 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 7/7] gnu: Add dvdstyler Thomas Danckaert
2017-05-03 13:04 ` Ludovic Courtès
2017-05-10 7:48 ` bug#26669: [PATCH 1/7] gnu: Add cdrtools Thomas Danckaert
2017-05-10 11:55 ` Ludovic Courtès
2017-04-26 17:15 ` Danny Milosavljevic [this message]
2017-04-26 16:59 ` Mathieu Othacehe
2017-05-03 12:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426191549.6774bd32@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=26669@debbugs.gnu.org \
--cc=post@thomasdanckaert.be \
--cc=thomas.danckaert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).