unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 26602@debbugs.gnu.org
Subject: bug#26602: Add aegisub
Date: Sat, 22 Apr 2017 20:54:34 -0400	[thread overview]
Message-ID: <20170423005434.GF10153@jasmine> (raw)
In-Reply-To: <20170422111824.70b34716@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

On Sat, Apr 22, 2017 at 11:18:24AM +0200, Julien Lepiller wrote:
> Hi,
> 
> here are three patches to add aegisub, a subtitle editor. Should the
> change to boost go in another branch? core-updates?

Assuming that `guix refresh -l boost` is accurate, I think it would be
appropriate for the next staging cycle (or core-updates, if that comes
first).

> From 2ade2478712cda0acdaeb0aae4b32c4e357f5e58 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 21 Apr 2017 21:42:55 +0200
> Subject: [PATCH 1/3] gnu: boost: Build with icu4c.
> 
> * gnu/packages/boost.scm (boost)[inputs]: Add icu4c.
> [arguments]: Add icu4c configure flag.

If you need this for aegisub, perhaps you could add a boost-with-icu
package just for aegisub, and then remove it after the primary boost
package has been rebuilt with icu4c.

> Subject: [PATCH 2/3] gnu: Add ffms2.
> 
> * gnu/packages/video.scm (ffms2): New variable.

> +   (synopsis "Cross-plateform wrapper around ffmpeg/libav")

s/plateform/platform

> +   (description
> +     "FFMpegSource is a wrapper library around ffmpeg/libav that allows
> +programmers to access a standard API to open and decompress media files")

Please end the sentence with a period (I think `guix lint` will catch
this).

> Subject: [PATCH 3/3] gnu: Add aegisub.
> 
> * gnu/packages/video.scm (aegisub): New variable.

> +    (synopsis "Subtitle engine")
> +    (description "Aegisub helps translators create subtitles for video")

How about this (based on text from the home-page)?

"Aegisub is a tool for creating and modifying subtitles.  Aegisub makes
it quick and easy to time subtitles to audio, and features many powerful
tools for styling them, including a built-in real-time video preview."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-04-23  0:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22  9:18 bug#26602: Add aegisub Julien Lepiller
2017-04-23  0:54 ` Leo Famulari [this message]
2017-06-18 11:13 ` [bug#26602] " Ricardo Wurmus
2017-07-30 16:35   ` Julien Lepiller
2017-07-31 14:58     ` Ludovic Courtès
2017-10-18 22:55       ` Ricardo Wurmus
2017-10-19 10:05         ` julien lepiller
2017-10-20 17:44           ` bug#26602: " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170423005434.GF10153@jasmine \
    --to=leo@famulari.name \
    --cc=26602@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).