unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Stefan Reichör" <stefan@xsteve.at>
Cc: 26546-done@debbugs.gnu.org
Subject: bug#26546: [PATCH] gnu: Add ponymix
Date: Mon, 17 Apr 2017 16:39:43 -0400	[thread overview]
Message-ID: <20170417203943.GA27911@jasmine> (raw)
In-Reply-To: <8760i2izz1.fsf@xsteve.at>

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Mon, Apr 17, 2017 at 09:41:22PM +0200, Stefan Reichör wrote:
> From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <stefan@xsteve.at>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
> 
> * gnu/packages/pulseaudio.scm (ponymix): New variable.

Thanks! Pushed as 05bdb5e64dea826552510cfeba8c63bcf487dcad with the
following changes:

> +             (uri (string-append "https://github.com/falconindy/ponymix/"
> +                                 "archive/" version ".tar.gz"))

To satisfy `guix lint`, I used (file-name) to make sure the source
tarball included the name of the package.

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))

Since origin snippets affect what you get from `guix build --source`, we
reserve them for fixing serious bugs and software freedom issues.
Guix-specific changes like this one are done in build phases, which
don't affect the source tarball. So, I moved this substitution into a
'patch-paths' phase.

> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")

I made some stylistic changes here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2017-04-17 20:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 19:41 bug#26546: [PATCH] gnu: Add ponymix Stefan Reichör
2017-04-17 20:39 ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170417203943.GA27911@jasmine \
    --to=leo@famulari.name \
    --cc=26546-done@debbugs.gnu.org \
    --cc=stefan@xsteve.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).