From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQXR-0004la-DQ
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:27:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQXO-0005sB-9s
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:27:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50965)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1czQXO-0005s4-6T
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQXO-0004ZX-1u
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:27:02 -0400
Subject: bug#26339: [PATCH 07/18] system: Add bootloader type.
Resent-Message-ID: <handler.26339.B26339.149227359817540@debbugs.gnu.org>
Date: Sat, 15 Apr 2017 18:26:34 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170415182634.4e2f9c68@scratchpost.org>
In-Reply-To: <20170402135242.2958-7-m.othacehe@gmail.com>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-7-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

LGTM mostly.  <Insert same comment about the same names as in the other patches>

> -(define* (grub-configuration #:optional (config (bootloader-configuration)))
> -  (bootloader-configuration
> -   (inherit config)
> -   (bootloader (@ (gnu packages bootloaders) grub))

Hmm.  Does that mean the user can't replace the bootloader package in the configuration?

> -(define* (grub-efi-configuration #:optional (config (bootloader-configuration)))
> -  (bootloader-configuration
> -   (inherit (grub-configuration config))
> -   (bootloader (@ (gnu packages bootloaders) grub-efi))))

Oh, so that's how.  I think it would be nice-to-have if the user could also override the bootloader package used.

> -   (install-procedure install-syslinux)))

Wait, so install-syslinux wouldn't need to be exported from this module at all, right?

Still nice that the user can use it - though is it worth exposing the installers?

Otherwise LGTM!