From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czQTZ-0003wV-3F for guix-patches@gnu.org; Sat, 15 Apr 2017 12:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czQTV-0002qu-W1 for guix-patches@gnu.org; Sat, 15 Apr 2017 12:23:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50949) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czQTV-0002qo-SJ for guix-patches@gnu.org; Sat, 15 Apr 2017 12:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czQTV-0004S1-Mb for guix-patches@gnu.org; Sat, 15 Apr 2017 12:23:01 -0400 Subject: bug#26339: [PATCH 04/18] bootloader: Add install procedures and use them. Resent-Message-ID: Date: Sat, 15 Apr 2017 18:22:22 +0200 From: Danny Milosavljevic Message-ID: <20170415182222.3e1cef0e@scratchpost.org> In-Reply-To: <20170402135242.2958-4-m.othacehe@gmail.com> References: <20170402135242.2958-1-m.othacehe@gmail.com> <20170402135242.2958-4-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26339@debbugs.gnu.org > + (symlink bootcfg (string-append directory "/bootcfg")))) ^^^^^^^ Is that safe? Will there only be one bootloader configuration at all times? What if the user uses multiple "guix system"s on the same machine? > + (install-boot-config bootcfg bootcfg-location target) > + (when install-bootloader > + (install-bootloader bootloader device target)) I think it's very good to finally seperate installation of the bootloader configuration and installation of the bootloader. On some architectures (for example ARM) it's very uncommon to replace the bootloader - and if you do it too often it would wear out the flash storage prematurely. >[exports] > + dd Errrr... was that exported on purpose? Sounds very implementation-detaily to me. > + #:install-bootloader Rather #:bootloader-installer or #:bootloader-installation ? Or leave it as is, doesn't matter much, I guess. I think a non-substantive for this is strange. > + #$(bootloader-configuration-install-procedure If it's not installing a procedure it should be bootloader-configuration-installation-procedure or bootloader-configuration-installer, I think. Otherwise LGTM!