From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55143)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQBE-0001jW-1X
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:04:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQB9-0004sY-0u
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:04:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50942)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1czQB8-0004sB-Re
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czQB8-00041o-FO
	for guix-patches@gnu.org; Sat, 15 Apr 2017 12:04:02 -0400
Subject: bug#26339: [PATCH 02/18] system: Add extlinux support.
Resent-Message-ID: <handler.26339.B26339.149227220115431@debbugs.gnu.org>
Date: Sat, 15 Apr 2017 18:03:12 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20170415180312.19632ddf@scratchpost.org>
In-Reply-To: <20170402135242.2958-2-m.othacehe@gmail.com>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-2-m.othacehe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

> +            bootloader-configuration-file-location

In my opinion in UNIX such a thing is called a "file name", so how about

    bootloader-configururation-file-name

?

> +            bootloader-configuration-file-procedure

How about

  bootloader-configuration-file-generator

Or

  bootloader-configuration-file-generation-procedure


?

> +            bootloader-configuration-install-procedure

How about

  bootloader-configuration-installer

or

  bootloader-configuration-installation-procedure 

?

> +    (match-lambda
> +      (($ <boot-parameters> label _ _ _ kernel kernel-arguments initrd)
> +       #~(format port "LABEL ~a
> +  MENU LABEL ~a
> +  KERNEL ~a
> +  FDTDIR ~a/lib/dtbs
> +  INITRD ~a
> +  APPEND ~a
> +~%"
> +                 #$label #$label
> +                 #$kernel #$kernel #$initrd
> +                 (string-join (list #$@kernel-arguments))))))

I think it would be better to use the field accessor procedures.

> +                    (* 10 timeout))

Magical conversion? Could use a comment...

Remainder of the patch LGTM.