unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
@ 2017-04-14 10:14 Mathieu Othacehe
  2017-04-14 10:23 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Othacehe @ 2017-04-14 10:14 UTC (permalink / raw)
  To: 26496

* Makefile.am (EXTRA_DIST): Add gnu/build/svg.scm.
* gnu/local.mk (GNU_SYSTEM_MODULES): Remove gnu/build/svg.scm.

It fixes the following build warnings:

gnu/build/svg.scm:36:12: warning: possibly unbound variable `cairo-create'
gnu/build/svg.scm:36:26: warning: possibly unbound variable `cairo-image-surface-create'
gnu/build/svg.scm:38:4: warning: possibly unbound variable `cairo-scale'
gnu/build/svg.scm:39:4: warning: possibly unbound variable `cairo-set-source-surface'
---
 Makefile.am  | 2 ++
 gnu/local.mk | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 99b455605..c9671e2d1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,6 +4,7 @@
 # Copyright © 2015, 2017 Alex Kost <alezost@gmail.com>
 # Copyright © 2016 Mathieu Lirzin <mthl@gnu.org>
 # Copyright © 2016, 2017 Mark H Weaver <mhw@netris.org>
+# Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
 #
 # This file is part of GNU Guix.
 #
@@ -394,6 +395,7 @@ EXTRA_DIST =						\
   TODO							\
   CODE-OF-CONDUCT					\
   .dir-locals.el					\
+  gnu/build/svg.scm					\
   build-aux/build-self.scm				\
   build-aux/compile-all.scm				\
   build-aux/hydra/evaluate.scm				\
diff --git a/gnu/local.mk b/gnu/local.mk
index 9385b3df9..e5973ab0d 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -459,7 +459,6 @@ GNU_SYSTEM_MODULES =				\
   %D%/build/linux-modules.scm			\
   %D%/build/marionette.scm			\
   %D%/build/shepherd.scm			\
-  %D%/build/svg.scm				\
   %D%/build/vm.scm				\
 						\
   %D%/tests.scm					\
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
  2017-04-14 10:14 bug#26496: [PATCH] build: Stop building gnu/build/svg.scm Mathieu Othacehe
@ 2017-04-14 10:23 ` Ludovic Courtès
  2017-04-14 13:17   ` Mathieu Othacehe
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2017-04-14 10:23 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 26496-done

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * Makefile.am (EXTRA_DIST): Add gnu/build/svg.scm.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Remove gnu/build/svg.scm.
>
> It fixes the following build warnings:
>
> gnu/build/svg.scm:36:12: warning: possibly unbound variable `cairo-create'
> gnu/build/svg.scm:36:26: warning: possibly unbound variable `cairo-image-surface-create'
> gnu/build/svg.scm:38:4: warning: possibly unbound variable `cairo-scale'
> gnu/build/svg.scm:39:4: warning: possibly unbound variable `cairo-set-source-surface'

Applied, thanks!

Ludo'.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
  2017-04-14 10:23 ` Ludovic Courtès
@ 2017-04-14 13:17   ` Mathieu Othacehe
  2017-04-14 15:17     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Othacehe @ 2017-04-14 13:17 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26496-done


> Applied, thanks!

Guix build is almost warning free !

The only remaining warnings are the consequence of using make-page-map
from (charting) in guix/scripts/size.scm, any thoughs ?

Thanks,

Mathieu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
  2017-04-14 13:17   ` Mathieu Othacehe
@ 2017-04-14 15:17     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2017-04-14 15:17 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 26496-done

Hi!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> The only remaining warnings are the consequence of using make-page-map
> from (charting) in guix/scripts/size.scm, any thoughs ?

I don’t think we can change that one: the idea is that this feature is
available when Guile-Charting is available, is missing otherwise.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-14 15:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-14 10:14 bug#26496: [PATCH] build: Stop building gnu/build/svg.scm Mathieu Othacehe
2017-04-14 10:23 ` Ludovic Courtès
2017-04-14 13:17   ` Mathieu Othacehe
2017-04-14 15:17     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).