From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26166@debbugs.gnu.org
Subject: bug#26166: [PATCH] gnu: cargo: Simplify unpacking.
Date: Fri, 14 Apr 2017 00:20:52 +0200 [thread overview]
Message-ID: <20170414002052.612ed7ae@scratchpost.org> (raw)
In-Reply-To: <87pogosznr.fsf@gnu.org>
Hi Ludo,
On Fri, 07 Apr 2017 22:58:32 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> It’s not immediately obvious that it’s a simplification. ;-)
Yeah well. Simple doesn't mean shorter. I think it's clearer to understand what it's doing when there a procedures that have names suggesting what it's for. :)
> For clarity it may help to replace the ‘let’ with “internal defines”,
Done.
> I don’t fully understand this file, but if it sounds good to you, we
> should apply it.
Yeah, Rust stuff is definitely not straightforward.
What this does is it sets up dependencies that are required to build cargo - just like cargo-vendor (an extension of cargo) would have set them up.
This avoids another bootstrapping problem (we would have to have cargo-vendor binaries). But cargo-vendor is an entirely avoidable dependency because the format of their package metadata is stable (and very minimal).
The format of the metadata is stable because cargo-vendor is the official way to bundle libraries with your custom project - we just bundle them on-the-fly to avoid bundling them in the cargo distribution file (like David's version did before) and previously having to distribute our own custom version of cargo.
cargo-vendor is a way that any developer on the world can use to bundle stuff for his Rust project *and check it into his git repository*. That means that metadata is on git repos Mozilla doesn't control - which means the format has to be stable (or at least backward-compatible).
Now we replace cargo-vendor entirely. Both cargo-build-system and this cargo package do cargo-vendors job in Guile (that's what install-rust-library does; now I wonder whether I should call it 'bundle-rust-library' instead. WDYT?).
next prev parent reply other threads:[~2017-04-13 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170319002844.19407-1-dannym@scratchpost.org>
2017-04-07 20:58 ` bug#26166: [PATCH] gnu: cargo: Simplify unpacking Ludovic Courtès
2017-04-13 22:04 ` bug#26166: [PATCH v2] " Danny Milosavljevic
2017-04-13 22:20 ` Danny Milosavljevic [this message]
2017-04-19 9:54 ` bug#26166: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414002052.612ed7ae@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=26166@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).