From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwVVY-0002XQ-UW for guix-patches@gnu.org; Fri, 07 Apr 2017 11:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwVVW-00088m-5y for guix-patches@gnu.org; Fri, 07 Apr 2017 11:09:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwVVV-00088e-VK for guix-patches@gnu.org; Fri, 07 Apr 2017 11:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cwVVV-0001KU-PN for guix-patches@gnu.org; Fri, 07 Apr 2017 11:09:01 -0400 Subject: bug#26391: [PATCH 0/1] Patching getcap and which in torsocks Resent-Message-ID: Date: Fri, 7 Apr 2017 15:08:08 +0000 From: ng0 Message-ID: <20170407150808.shu6vxnlq4phd6cv@abyayala> References: <20170407140511.25564-1-bavier@member.fsf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170407140511.25564-1-bavier@member.fsf.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier Cc: 26391@debbugs.gnu.org Eric Bavier transcribed 0.8K bytes: > This patches references to the 'getcap' and 'which' programs in 'torsocks' > so that users that don't have either of those packages installed in their > profiles do not see confusing output about them missing. Usually torsocks > will still function in that case, but it's probably better to have them > available. > > I've so far done this sort of thing for several packages with shell scripts, > and each time I'm convinced that this method is better than declaring the > inputs in propagated-inputs. But I think I'd feel more sure of myself if we > had a short "Packaging shell scripts" section in the manual that outlined > best-practices-of-the-moment. Would that be useful? > > Eric Bavier (1): > gnu: torsocks: Patch references to 'getcap' and 'which'. > > gnu/packages/tor.scm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > -- > 2.12.2 > > I have not run the patch, but the code looks good to me. The "dependencies" are not obvious, so your proposed change is okay.