unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <contact.ng0@cryptolab.net>
To: Eric Bavier <bavier@member.fsf.org>
Cc: 26391@debbugs.gnu.org
Subject: bug#26391: [PATCH 0/1] Patching getcap and which in torsocks
Date: Fri, 7 Apr 2017 15:08:08 +0000	[thread overview]
Message-ID: <20170407150808.shu6vxnlq4phd6cv@abyayala> (raw)
In-Reply-To: <20170407140511.25564-1-bavier@member.fsf.org>

Eric Bavier transcribed 0.8K bytes:
> This patches references to the 'getcap' and 'which' programs in 'torsocks'
> so that users that don't have either of those packages installed in their
> profiles do not see confusing output about them missing.  Usually torsocks
> will still function in that case, but it's probably better to have them
> available.
> 
> I've so far done this sort of thing for several packages with shell scripts,
> and each time I'm convinced that this method is better than declaring the
> inputs in propagated-inputs.  But I think I'd feel more sure of myself if we
> had a short "Packaging shell scripts" section in the manual that outlined
> best-practices-of-the-moment.  Would that be useful?
> 
> Eric Bavier (1):
>   gnu: torsocks: Patch references to 'getcap' and 'which'.
> 
>  gnu/packages/tor.scm | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> -- 
> 2.12.2
> 
> 

I have not run the patch, but the code looks good to me.
The "dependencies" are not obvious, so your proposed change is okay.

  parent reply	other threads:[~2017-04-07 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 14:05 bug#26391: [PATCH 0/1] Patching getcap and which in torsocks Eric Bavier
2017-04-07 14:05 ` bug#26392: [PATCH 1/1] gnu: torsocks: Patch references to 'getcap' and 'which' Eric Bavier
2017-04-10  9:48   ` Ludovic Courtès
2017-04-10 13:50     ` Eric Bavier
2017-04-07 15:08 ` ng0 [this message]
2017-04-08 12:28 ` bug#26391: [PATCH 0/1] Patching getcap and which in torsocks Ludovic Courtès
2017-04-09  3:36 ` Eric Bavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407150808.shu6vxnlq4phd6cv@abyayala \
    --to=contact.ng0@cryptolab.net \
    --cc=26391@debbugs.gnu.org \
    --cc=bavier@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).