From: Tobias Geerinckx-Rice <me@tobias.gr>
To: 26314@debbugs.gnu.org
Subject: bug#26314: [PATCH] substitute: Send ‘User-Agent’ header.
Date: Thu, 30 Mar 2017 20:44:39 +0200 [thread overview]
Message-ID: <20170330184439.8896-1-me@tobias.gr> (raw)
* guix/scripts/substitute.scm (narinfo-request): Pass ‘User-Agent’ #:headers
to ‘build-request’.
---
Guix,
This makes the User-Agent sent to substitute servers consistent.
Currently, ‘http-fetch’ (used to download .nars) sets it to ‘GNU Guile’,
while http-multiple-get (used to download .narinfos) leaves it empty.
(This brings the number of scattered '"GNU Guile"' user-agent settings
in Guix to 5, but moving it to %guix-default-http-user-agent does not
strike me as a meaningful improvement.)
Kind regards,
T G-R
guix/scripts/substitute.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index faeb01912..d3bccf4dd 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -520,8 +520,9 @@ indicates that PATH is unavailable at CACHE-URL."
(define (narinfo-request cache-url path)
"Return an HTTP request for the narinfo of PATH at CACHE-URL."
(let ((url (string-append cache-url "/" (store-path-hash-part path)
- ".narinfo")))
- (build-request (string->uri url) #:method 'GET)))
+ ".narinfo"))
+ (headers '((User-Agent . "GNU Guile"))))
+ (build-request (string->uri url) #:method 'GET #:headers headers)))
(define* (http-multiple-get base-uri proc seed requests
#:key port (verify-certificate? #t))
--
2.37.4
next reply other threads:[~2017-03-30 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 18:44 Tobias Geerinckx-Rice [this message]
2017-03-31 8:12 ` bug#26314: [PATCH] substitute: Send ‘User-Agent’ header Ludovic Courtès
2017-03-31 13:42 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330184439.8896-1-me@tobias.gr \
--to=me@tobias.gr \
--cc=26314@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).