[bug#71317] [PATCH] fixed dependencies for latexindent

[bug#71317] [PATCH] fixed dependencies for latexindent

[aria]

 From eec57fe778c5dd90f1a773793740a39177e3a9a4 Mon Sep 17 00:00:00 2001
 From: Aria Nolan <aria@chytrid.org>
Date: Sat, 1 Jun 2024 15:01:16 -0400
Subject: [PATCH] fixed dependencies for latexindent

Change-Id: I70e90419b0a513c66292218ae307fc186465ca60
---
  gnu/packages/tex.scm | 1 +
  1 file changed, 1 insertion(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 4e46c1a..1df707f 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -38510,6 +38510,7 @@ (define-public texlive-latexindent
      (build-system texlive-build-system)
      (arguments (list #:link-scripts #~(list "latexindent.pl")))
      (inputs (list perl))
+    (propagated-inputs (list perl perl-yaml-tiny perl-file-homedir))
      (home-page "https://ctan.org/pkg/latexindent")
      (synopsis "Indent a LaTeX document, highlighting the programming 
structure")
      (description
-- 
2.45.1

[bug#71317] [PATCH] fixed dependencies for latexindent

[Nicolas Goaziou via Guix-patches via]

Hello,

aria@chytrid.org writes:

>  From eec57fe778c5dd90f1a773793740a39177e3a9a4 Mon Sep 17 00:00:00 2001
>  From: Aria Nolan <aria@chytrid.org>
> Date: Sat, 1 Jun 2024 15:01:16 -0400
> Subject: [PATCH] fixed dependencies for latexindent

Thank you.

>       (inputs (list perl))
> +    (propagated-inputs (list perl perl-yaml-tiny perl-file-homedir))

Perl is already an input, it should not be a propagated input, too.
`perl-yaml-tiny' and `perl-file-homedir' should also be moved to inputs.
In that case, you will probably need to add a phase such as this one:

          (add-after 'link-scripts 'wrap-perl-script
            (lambda _
              (wrap-program (string-append #$output "/bin/latexindent")
                `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))


Could you send an updated patch?


Regards,
-- 
Nicolas Goaziou

[bug#71317] [PATCH] fixed dependencies for latexindent

[Nicolas Goaziou via Guix-patches via]

Hello,

Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:

> Perl is already an input, it should not be a propagated input, too.
> `perl-yaml-tiny' and `perl-file-homedir' should also be moved to inputs.
> In that case, you will probably need to add a phase such as this one:
>
>           (add-after 'link-scripts 'wrap-perl-script
>             (lambda _
>               (wrap-program (string-append #$output "/bin/latexindent")
>                 `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))

I went ahead and applied the changes suggested, then pushed it.

Thank you for your initial report!

Regards,
-- 
Nicolas Goaziou