From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id tVNcNiXGGmEfQwAAgWs5BA (envelope-from ) for ; Mon, 16 Aug 2021 22:10:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sBFsMSXGGmHCBgAAB5/wlQ (envelope-from ) for ; Mon, 16 Aug 2021 20:10:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 49215DD11 for ; Mon, 16 Aug 2021 22:10:13 +0200 (CEST) Received: from localhost ([::1]:35450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFiw0-0005qt-7c for larch@yhetil.org; Mon, 16 Aug 2021 16:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFivq-0005qi-QS for guix-patches@gnu.org; Mon, 16 Aug 2021 16:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFivq-0007xo-Jc for guix-patches@gnu.org; Mon, 16 Aug 2021 16:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFivq-0005rA-Em for guix-patches@gnu.org; Mon, 16 Aug 2021 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50052] [PATCH] Add prusa-slicer Resent-From: Daniel Trujillo Viedma Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Aug 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50052 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ivan Gankevich Cc: 50052@debbugs.gnu.org Received: via spool by 50052-submit@debbugs.gnu.org id=B50052.162914457022470 (code B ref 50052); Mon, 16 Aug 2021 20:10:02 +0000 Received: (at 50052) by debbugs.gnu.org; 16 Aug 2021 20:09:30 +0000 Received: from localhost ([127.0.0.1]:51087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFivG-0005qJ-Cx for submit@debbugs.gnu.org; Mon, 16 Aug 2021 16:09:30 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFivB-0005pz-24 for 50052@debbugs.gnu.org; Mon, 16 Aug 2021 16:09:24 -0400 Received: by mail-wr1-f43.google.com with SMTP id k8so6300145wrn.3 for <50052@debbugs.gnu.org>; Mon, 16 Aug 2021 13:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6kGK5jiOx3Dy+KMebAi5MSl8UPsrI/AFYnQnlzt3SrA=; b=ALCcVB2Z6ryUgyoyVFARwz9SEKebo4Hemw51/J6ws4zDJiorBvEKkNQiJShf63SXN1 BuYAZGMhBfoz2hLlpuGJeB+p65/SEuzVPvdu/J7CarZ0k+W7ZCePuXG9IpZ7bypNwI4m 3AI7zcrPifXE3Fuh/ojInso5VxZbQXsaWUZOFpXGtmviA8wt13V/DEkvg68875uCnH+A L56ImofeuT7IjKTGYBMEIvh1Ks0Luor8bI6T8Ozja+Sm0tvabgLQDPYRuHBK8YmMDnSt fesbRSkZh4uLnzeaoD5XQeJSs/ZjimuIPfb/JESdsTQ0voe/Z/iBGJOWLxe7gs73QX+P cXgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6kGK5jiOx3Dy+KMebAi5MSl8UPsrI/AFYnQnlzt3SrA=; b=AmvDj2KAZIwDChA4jJ+wRQVQw5521x5GnszwpuBULMspR9LQ4BOfRXeOyJC1IZh7S8 1D97zSXuX7PcXavhAIqlAF0YK7NtEJfplNxp/aVgNqG5ehcxalXfdv1nKaM6+A8yY46w vmV0LnK0PQr63P5aU/GS66oAk51NMEsxxL9fOnQgK1k0rsW9qZMleug1kZ3GoLKlsWWB TYa/JJ9wjomzrFVw8n+dnl04QIxOODs5m+gsaY0etyUTRexRb0SR4rNzEm11GoRWK6KY 1YbPtvDWak7tggXPizXsUueatiJ6JXYpXLOW+5t1GF0VoUmmTOybVzLAoUSQDb+TNUCK zdog== X-Gm-Message-State: AOAM531wpCEviN2eEfx1rA9JQVZgIbUYoSh+qcnd8yoBuUhshJFMZHgJ +6k44rgBig1FWvF75OO7+wM/mjX6LK/UXg== X-Google-Smtp-Source: ABdhPJzkAKLNHMVoqXSJlLYH1GMCyF8QSyUx29uZY1SlsqD1ufyOVXxgRD4RWA2rULk1DAJ6IiuPGg== X-Received: by 2002:adf:e588:: with SMTP id l8mr245894wrm.16.1629144555162; Mon, 16 Aug 2021 13:09:15 -0700 (PDT) Received: from [192.168.0.13] ([37.223.119.203]) by smtp.gmail.com with ESMTPSA id a9sm226870wrv.37.2021.08.16.13.09.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 13:09:14 -0700 (PDT) References: <0654f9e7-8c1d-aa4c-3240-54faf3defb2f@gmail.com> From: Daniel Trujillo Viedma Message-ID: <1e9213ed-4630-44a0-53c4-747f41f97ad7@gmail.com> Date: Mon, 16 Aug 2021 22:09:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629144613; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6kGK5jiOx3Dy+KMebAi5MSl8UPsrI/AFYnQnlzt3SrA=; b=YI4QRlAO3fkm4Tg7pN9RTnLd/v4JfWv9TZjLSkA+IUFKH82P0PSGif+tpE9B2UV3FKTeWI rqNDhGh70f8fxdLAl0MGfP28NGVOqBhTHl0WcBV4bRjr/c8FTOuymyBpeWz/SjsBLz8Wio W9WcHCB7IZxr/MyzbdLrfnxSZTVAjhb8jSK4VlkiFsON1sX0643zqiRJx2IMVy4cUZi6NB tSf5wLeWfM7leTf8aof6+m5quRc7/A8NFSU437iI3DhnEo7E6RI+xR0cCgjWt+3+u+Pud7 uerKhLBkRCAOE83PFfnXAZsaQ708M3rKDrRCYMNV+vPwe1CYHl3ofdrfZ9F23g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629144613; a=rsa-sha256; cv=none; b=NuW4hV8tRGRTcvZ0DX82f9ACS0p4hqxJrBQ30TeAH4ka/DcMRho+SbTXgkpIy01F6uNjhh caYS1xI1zy6Bh6CELT5tRoTZd35XIMGDTdfV9ABS2WtLawuV4pTvhwsnM4/JRqoOfDt9Ob tG9ZMgUDcZJcxChWw85g7p5G9NSWClAQD+KY5+vO28yO+/ZebDksEaZu2VywahaCNTh+TK Crsyob7dWT99zajXBK4Y2bgHWBCT0fgJaxe5hGBWIz+0CEZEF2LQ8PPzzDiwIwF/3I4pCl jDBEFU7SvD1QxT9QdIwM56BLMNxNuIK89FTKNyVZhpRg7JOo6zIiszAWN0Ijvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ALCcVB2Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ALCcVB2Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 49215DD11 X-Spam-Score: -1.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: Fa+L7Vv7LaQ+ Hi, Ivan! You're completely right, I should have to searched more thoroughly any ongoing effort packaging prusa-slicer. At this point, the best thing I should do is to send an email to the list to discard my package and encourage to take a look at yours, since are way more advanced than mine. You are also right with the -DSLIC3R_FHS=1. I thought that that will make the executable look for the resources outside the /gnu/stare folder, where nothing would be found, but it works, can you briefly point me to what is happening? Thank you so much! El 16/8/21 a las 9:49, Ivan Gankevich escribió: >> Hi! I'm Daniel Trujillo, > > Hello, Daniel! > > >> I don't know if these kind of packages are of interest, but this is >> PrusaSlicer [0], a software to prepare 3D printings (hence I put it >> in engineering.scm). > > I have submitted “prusa-slicer” together with “libigl” on July 23 but > did’t get any > response: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49713 > > We should probably check prior submissions to not duplicate our effort. > > >> The packaged version, 2.3.3 is the latest stable available at this >> moment. But this version has as important problem [1]: It cannot be >> invoked just naming the executable (through $PATH), because then, it >> can't locate the resources directory. I learned **the hard way** that >> the fix was applied *after* the release of the 2.3.3 version, so I >> decided to backport the fix adding a patch because it's a >> show-stopper to have to type the path to the executable in >> /gnu/store/... That's the reason why the patch attached to this email >> contains, not only the additions to engineering.scm, but also a patch >> that implements the solution in the version 2.3.3 codebase (It's >> quite simple, it uses a boost function to determine the path to the >> executable rather than relying on argv[0]). > > This issue is fixed by adding “-DSLIC3R_FHS=1” to #:configure-flags. > No need to patch the source code. > > >> * In order for the above $PATH issue fix to work, it's crucial that >> the cmake variable SLIC3R_FHS is set to off. This is the default >> value according to the CMakeLists.txt, but because it's so important, >> probably it should have been included in the configure-flags >> argument? Just for clarity. > > Set it to ON and you don’t have to patch the code. > > >> I hope everything is in order, I'm looking forward to see your >> comments, and hope I can start contributing more packages to Guix!! > > Prusa slicer bundles a lot of third-party libraries. Most of them contain > prusa-specific modifications, but some don’t. “libigl”, “eigen” and > “hidapi” can be > unbundled, so that we can use versions of these libraries provided by > Guix. > >> +         ("cereal" ,cereal) > > You need to patch “cereal” library definition in order for Prusa > slicer to find > this library. I have included this in my patch as well. > > > Regards, > Ivan