From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4Ht3LAKdsmVxSAAA62LTzQ:P1 (envelope-from ) for ; Thu, 25 Jan 2024 18:40:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 4Ht3LAKdsmVxSAAA62LTzQ (envelope-from ) for ; Thu, 25 Jan 2024 18:40:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="hPdFW/Wt"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706204418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fYJJrlnravttSfXEj9f3GMGb00L4Hr7ir0Q5AcGVBCw=; b=kEr0WVDY522rb6WxZmvb9MzH5Ty5jNn/1peyLeCRbEmAfSJu2+rFo4I5zb5r+PJvas0CeQ 0hur+WB7bWCT/TVqNOEUHkiKzufnResUrtFtx9+cmx7D1KN8cIMvndFbx4ej0Dn2iWl19w iltuqg7Bhxfizkxgl2k55/pnehBVOHU6lxS/0tfOu74rrukiZRMOg2RgUuQVR5ZayF9rPB sJ0j9HmE+azFuQU28+tpmugZxuevHSetbZu2dFoAL27hjaeY2kpQxIqPEe4Lm4L4PR4v6L 4byUGRulzF5pjdCzE17/Ktm4J6iBMxc3+1WCrXShDas9o4rCXV+57bhCVs/hFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="hPdFW/Wt"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706204418; a=rsa-sha256; cv=none; b=d8lX1NoIY10mogcB/IdqJ9z9kCiMfeObvmTcG2a+vnLAUh82OLgir6SOfs7vozKM8Pxfxg NYtJTyDigRh+vHF3+jtXH/J9NSUt9Bs4pPdhiTxM8NE0X/1DqDOCjouKnHEVpApzgZH7kq GCwO3ZON3+5i3CXAl5Gpr2nQfm/+A3AmTHu+GeC7/RPrwHMnuqSCIozk+c182801ipzzfq 90UHyfneV9BntxoG8NSDasQXdEU+hvxqf9DqoovQf3ZPR0QzEuhx/wxNjMdwNKLUfXZ2iw vxZYagBygaAjKj+hpKBd/hWMMirmiuTD9M9QXXQM/NxCwftw3SRXyzj7OHQnSg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8AE7A54554 for ; Thu, 25 Jan 2024 18:40:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT3hm-0002u2-Hd; Thu, 25 Jan 2024 12:39:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT3hl-0002qQ-2l for guix-patches@gnu.org; Thu, 25 Jan 2024 12:39:57 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT3hk-00019X-QH for guix-patches@gnu.org; Thu, 25 Jan 2024 12:39:56 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT3hq-00049S-D0 for guix-patches@gnu.org; Thu, 25 Jan 2024 12:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68716] [PATCH gnome-team RFC 1/3] services: Modularise gnome-desktop-configuration. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Jan 2024 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68716 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vivien Kraus , 68716@debbugs.gnu.org Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com Received: via spool by 68716-submit@debbugs.gnu.org id=B68716.170620435415893 (code B ref 68716); Thu, 25 Jan 2024 17:40:02 +0000 Received: (at 68716) by debbugs.gnu.org; 25 Jan 2024 17:39:14 +0000 Received: from localhost ([127.0.0.1]:49126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT3h4-00048H-0o for submit@debbugs.gnu.org; Thu, 25 Jan 2024 12:39:14 -0500 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]:59643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT3h1-000482-4M for 68716@debbugs.gnu.org; Thu, 25 Jan 2024 12:39:13 -0500 Received: by mail-lj1-x242.google.com with SMTP id 38308e7fff4ca-2cf2b218c62so24945771fa.2 for <68716@debbugs.gnu.org>; Thu, 25 Jan 2024 09:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706204339; x=1706809139; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=fYJJrlnravttSfXEj9f3GMGb00L4Hr7ir0Q5AcGVBCw=; b=hPdFW/WtMXspZl+9FlTo+XkSDYVLPjXTt4EV7ypaxJjldEKuZqSF0BIAEEBGReYv+m DcFds5mlz/g5LHD9kPtzCn3t25nrF3YqYj9QwQBbu04BKNMhh6op+cfcWh8MGZwSGpUn kY4x9q1AZKl0GNN3jkH0s9MF2QAZtg/tmbioJlm5fGbxLP/sjfs1q3XeliOKru1y+CC/ qo6/07z4CapDMTCkpO5ekX8KnbPASplrESx6R6TJVVLsUP7xfh0Ti8GZ9wqFNsvsgYTH 2V8g6SYLJoc4FdXTpvonpXOSBV19Rt1IGO6Oylp3yW2Fg7GrRkD4twSZeS04rMTjP30q V+qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706204339; x=1706809139; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fYJJrlnravttSfXEj9f3GMGb00L4Hr7ir0Q5AcGVBCw=; b=q9IcKGmynAVKoQZUxAco6l1O7crlPz6Hz27BuK1NNAInkNOY/U6VTPQryLtHKo+Yxx w/bEf/B2fZvxDHtmIB95dFrn07QSgTPYIUbFPVvCV9ntUUsH+CraHcKfiEKVAobCM3Sg BviF7RAdgR4yGENtO6TRZPcAJ95ckEJYhIrSKeWPsPRcYAsopt5R5JGTEhbKYjukWVim z6Kjb4FpPq5rnXb9hSMxclsmU+dGGeOxcE51DazQXJuMAY4/hKCB8xH0WSi8QZbVkB9U LkFZrcmCOi2+h0wK/NMd0kJ8FdkpzIxLE4/432ntNivqwjNNfVHDwkfr3zQadAAm3eVH npCA== X-Gm-Message-State: AOJu0YyNfvFs84HyGrgGCC3wkJyn6Gu9FtJZqbLqML4sD3T85Wb4Jfbj omTtHHcf29tT+FULhIwZunjQZGp6ISoyjy9/gjxMBaokPyhB+2hb X-Google-Smtp-Source: AGHT+IFsqzzQ0EkqaKIuS6R0xPZiZWGFtY24fRwdVz/hlVWR1iGePcJtFMzyTNuEabWaBntV2GKQ8w== X-Received: by 2002:a05:6512:33ca:b0:50e:66c1:f886 with SMTP id d10-20020a05651233ca00b0050e66c1f886mr52997lfg.148.1706204338686; Thu, 25 Jan 2024 09:38:58 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a17-20020a1709066d5100b00a3483e12dd2sm185044ejt.16.2024.01.25.09.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 09:38:58 -0800 (PST) Message-ID: <1dc89038a0afc877b7b0e7de3166242406be0033.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 25 Jan 2024 18:38:57 +0100 In-Reply-To: <4d7b7ed7da044d557271f02b3d90ba87ce12ccf0.camel@planete-kraus.eu> References: <4d7b7ed7da044d557271f02b3d90ba87ce12ccf0.camel@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.84 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: 3.84 X-Migadu-Queue-Id: 8AE7A54554 X-TUID: nJOMyI6nAEqr Am Donnerstag, dem 25.01.2024 um 18:12 +0100 schrieb Vivien Kraus: > Hello! >=20 > Thank you for this series. >=20 > Le jeudi 25 janvier 2024 =C3=A0 16:35 +0100, Liliana Marie Prikler a > =C3=A9crit=C2=A0: > > =C2=A0(define (gnome-udev-rules config) > > =C2=A0=C2=A0 "Return the list of GNOME dependencies that provide udev r= ules." > > -=C2=A0 (let ((gnome (gnome-desktop-configuration-gnome config))) > > -=C2=A0=C2=A0=C2=A0 (gnome-packages gnome '("gnome-settings-daemon")))) > > +=C2=A0 (let* ((gnome (gnome-desktop-configuration-gnome config)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (shell (gnome-desktop= -configuration-shell config))) > > +=C2=A0=C2=A0=C2=A0 (or (any (match-lambda > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 ((and pkg (=3D package-name "gnome-settings-daemon")) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (list pkg)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (_ #f)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 shell) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (and (maybe-value-set? gnom= e) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (gnome-packages gnome '("gnome-settings-daemon"))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (raise > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (condition > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (&error-locatio= n > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (location= (gnome-desktop-configuration-source-location > > config))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (&message (mess= age (G_ "Missing gnome-settings- > > daemon")))))))) > > =C2=A0 > Is there a reason why we can=E2=80=99t just add everything (like what you= r > new gnome-profile function does)? >=20 > As far as I understand, the user doesn=E2=80=99t have a say over which > individual rules will be used, among the rules that come from the > same package. So if we want the user to have full control over the > rules that are picked, then the current configuration record does not > allow sufficient precision. >=20 > Also, we now have udev hardware files. I=E2=80=99m not sure we have any G= NOME > packages that install hardware files, but the user might have some. > The gnome-udev-rules function name is misleading now (sorry, my bad, > I should have renamed it when the udev service changed), because > every package listed here will also have its hardware files > installed, not just rules. If you want to pick rules separately from > hardware files, you have to use file->udev-rule, file->udev-hardware > (or udev-rule and udev-hardware) from (gnu services base). That is a good point that I've been debating with myself. For v1, I simply aimed at service equivalence, but I have yet to decide whether that's desirable or useful. I don't want to simply drop all packages into udev-service-type, though, unless there's some clever filtering going on behind the back. I'm not sure at which stage we could efficiently check for the presence of these magic directories and add them. > > @@ -1422,7 +1566,7 @@ (define gnome-desktop-service-type > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (service-e= xtension polkit-service-type > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gnome-polkit-settings) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (service-e= xtension profile-service-type > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (compose list gnome-desktop- > > configuration-gnome)))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 gnome-profile))) > > =C2=A0=C2=A0=C2=A0 (default-value (gnome-desktop-configuration)) > > =C2=A0=C2=A0=C2=A0 (description "Run the GNOME desktop environment."))) > I think the gnome-desktop-service-type could be easily made > extensible, so that e.g a gnome-circle-service-type could add all the > circles applications in their respective sections. >=20 > Maybe it could be extended with other instances of gnome-desktop- > configuration? It looks to me that merging multiple instances is > quite easy, as you could just merge the lists for each category, and > the "gnome" field of the extension could simply be ignored. There are > still issues, such as: how can a service extension replace a package > with a conflicting one. Maybe that case is too far out of scope. In my humble opinion, instantiating services twice and merging them doesn't make sense for a number of services, with gnome being one of them. We already have an escape hatch for further packages and configuration records support extension via inheritance (+ public accessors). > That being said, the extensibility of the gnome-desktop-service-type > is not very much needed, because we can also extend the udev, polkit > and profile services directly. That too. Cheers