From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maximilian Heisinger <mail@maxheisinger.at>
Cc: 57181@debbugs.gnu.org
Subject: [bug#57181] [PATCH] gnu: maths: Add newer SAT solvers cryptominisat5 and kissat
Date: Sat, 13 Aug 2022 22:05:02 +0200 [thread overview]
Message-ID: <1dbd4bac9403ed4dd17de75dfc2d210daf2d2ea3.camel@gmail.com> (raw)
In-Reply-To: <db92dd9dd2a11a9c6dd576e898491a96ab43dba3.camel@maxheisinger.at>
Hi,
Am Samstag, dem 13.08.2022 um 17:23 +0200 schrieb Maximilian Heisinger:
> * gnu/packages/maths.scm (cryptominisat5): Add package.
> * gnu/packages/maths.scm (kissat): Add package.
Split into two patches, one for cryptominisat and one for kissat.
> ---
> gnu/packages/maths.scm | 64
> ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index c79058ab42..4a58b9eb3f 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -7311,6 +7311,70 @@ (define-public minisat
> "http://minisat.se/MiniSat.html")
> (license license:expat))))
>
> +(define-public cryptominisat5
> + (package
> + (name "cryptominisat5")
> + (version "5.8.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/msoos/cryptominisat")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "00hmxdlyhn7pwk9jlvc5g0l5z5xqfchjzf5jgn3pkj9xhl8yqq50"))))
> + (build-system cmake-build-system)
> + (arguments `(#:tests? #false))
Always state why tests are disabled.
> + (inputs (list zlib boost))
> + (synopsis "Advanced incremental SAT solver")
"Incremental SAT solver" is probably enough.
> + (description
> + "Provides CryptoMiniSat, an advanced incremental SAT solver.
> The system
> +has 3 interfaces: command-line, C++ library and python.
I'd shorten this to "CryptoMiniSat is an incremental SAT solver with
three interfaces: command-line, C++ library and Python".
> The command-line
> +interface takes a cnf as an input in the DIMACS format with the
> extension of
Use @abbrev for CNF (also capitalize).
> +XOR clauses. The C++ and python interface mimics this and also
> allows for
> +incremental use: assumptions and multiple solve calls. A C
> compatible wrapper
> +is also provided.")
Doesn't that technically make it a fourth interface?
> + (home-page "https://github.com/msoos/cryptominisat")
> + (license license:expat)))
> +(define-public kissat
> + (package
> + (name "kissat")
> + (version "3.0.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/arminbiere/kissat")
> + (commit (string-append "rel-" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "04x4w760srbdi4zci0s747qxk717x5d2x59ixraxh5104s9nyn8b"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f
Specify why.
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (invoke "./configure")))
You probably want to (apply invoke "./configure" configure-flags).
> + (replace 'install
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (install-file
> + "build/kissat"
> + (string-append (assoc-ref outputs "out") "/bin")))))))
Is this the only thing to install?
> + (home-page "https://github.com/arminbiere/kissat")
> + (synopsis "Bare-metal SAT solver after the KISS principle
> principle
> +written in C")
"Bare-metal SAT solver" probably suffices.
> + (description
> + "Kissat is a \"keep it simple and clean bare metal SAT solver\"
> written
"bare metal SAT solver" again probably suffices. If you want to be
generous with advertising terms, clean may be added, but I don't think
it adds useful information.
> +in C. It is a port of CaDiCaL back to C with improved data
> structures, better
> +scheduling of inprocessing and optimized algorithms and
> implementation.")
> + (license license:gpl3+)))
> +
Cheers
next parent reply other threads:[~2022-08-13 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <db92dd9dd2a11a9c6dd576e898491a96ab43dba3.camel@maxheisinger.at>
2022-08-13 20:05 ` Liliana Marie Prikler [this message]
[not found] ` <1840023126.104586.1660505267957@ox93.mailbox.org>
2022-08-14 22:07 ` [bug#57181] [PATCH] gnu: maths: Add newer SAT solvers cryptominisat5 and kissat Liliana Marie Prikler
2022-08-15 10:50 ` Maximilian Heisinger
2022-08-15 13:27 ` Liliana Marie Prikler
2022-08-17 6:26 ` mail
2022-08-17 20:16 ` Liliana Marie Prikler
2022-08-13 15:34 Maximilian Heisinger
2022-10-15 14:45 ` [bug#57181] [PATCH v2 1/4] gnu: Add aiger Liliana Marie Prikler
2022-10-15 14:45 ` [bug#57181] [PATCH v2 2/4] gnu: Add lingeling Liliana Marie Prikler
2022-10-15 14:46 ` [bug#57181] [PATCH v2 3/4] gnu: Add louvain-community Liliana Marie Prikler
2022-10-15 14:47 ` [bug#57181] [PATCH v2 4/4] gnu: Add cryptominisat Liliana Marie Prikler
2022-11-26 13:15 ` bug#57181: " Liliana Marie Prikler
2022-11-27 17:48 ` [bug#57181] " Maximilian Heisinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbd4bac9403ed4dd17de75dfc2d210daf2d2ea3.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=57181@debbugs.gnu.org \
--cc=mail@maxheisinger.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).