unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Attila Lendvai <attila@lendvai.name>
Cc: 64929@debbugs.gnu.org
Subject: [bug#64929] [PATCH] gnu: gcc-toolchain: Create a 'bin/cc' symlink.
Date: Mon, 21 Aug 2023 17:08:57 +0200	[thread overview]
Message-ID: <1ccea740-deb5-2032-b02f-1e46547d7624@telenet.be> (raw)
In-Reply-To: <pcKZHfrO5IF04jMS67HDb2tqvN8rIEZcbcblAuM2fjUZ0OJQL4GQko4SyFRuY6JJ06rCNOZeA4S1Gs9wrtu9IyN2MLjGtMmWZQXhDXxkf90=@lendvai.name>


[-- Attachment #1.1.1: Type: text/plain, Size: 2302 bytes --]

Op 21-08-2023 om 16:30 schreef Attila Lendvai:
> ok, i see why this won't work.
> 
> CC=(cc-for-target) is fine for packages, but the use-case that i'd like to facilitate is `guix shell gcc-toolchain some-other-deps` and then build a project manually from the opened shell.
> 
> any ideas how to help/handle that use-case without disrupting cross-compilation for packages?
>

IIUC, gcc-toolchain isn't used for "guix build" (I'm not really sure 
though), so if that's your use case, your current patch would work 
without problems w.r.t. cross-compilation.  Rhetorical question: why 
didn't I think of this when writing my previous message?

However, (assuming my assumption about gcc-toolchain is correct), 
applying the patch would create a discrepancy between the build 
environment from "guix build/guix shell -D ..." and "guix shell 
gcc-toolchain more-deps", which isn't nice and is potentially confusing.

I was going to suggest that the solution would be to modify your script 
to look for TARGET-cc when cross-compiling, but while that would be an 
improvement it wouldn't solve anything as Guix doesn't have TARGET-cc.

For an alternate proposal (which I think has been proposed before, but I 
don't recall where), it might be possible to create 'symlink' packages 
"symlink-cc-gcc" and "symlink-cc-clang", that respectively have the 
cc->gcc and cc->clang symlink (also cc->clang should be removed from the 
clang package, otherwise there is a collision and a preference for clang).

(I'm thinking of Debian's alternative system, but simplified (no 
priorities!) and based on packages.)

For --with-c-toolchain (*) (**) and the cross-compilation issue I 
mentioned, these should be forbidden for use in Guix packages (as in, 
"guix lint" doesn't like it/not accepted in Guix proper, if some other 
channel does it anyway, it's not recommended, but also not really any of 
Guix' concern).

(*) I don't know if clang and cross-compilation is supported yet by 
--with-c-toolchain.
(**) though with-c-toolchain isn't truly a concern, as it could simply 
adjust the symlink inputs ...

(I have the impression that I previously was against such symlink 
packages, but I don't recall actually writing a message about it.)

Best regards,
Maxime Devos.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  reply	other threads:[~2023-08-21 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 11:50 [bug#64929] [PATCH] gnu: gcc-toolchain: Create a 'bin/cc' symlink Attila Lendvai
2023-08-21 13:40 ` Maxime Devos
2023-08-21 14:30   ` Attila Lendvai
2023-08-21 15:08     ` Maxime Devos [this message]
2024-02-28 20:59 ` John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ccea740-deb5-2032-b02f-1e46547d7624@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=64929@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).