unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: Christopher Baines <mail@cbaines.net>
Cc: 39109-done@debbugs.gnu.org
Subject: bug#39109: [PATCH] gnu: red-eclipse: Update to 2.0.0.
Date: Wed, 15 Jan 2020 22:47:22 -0500	[thread overview]
Message-ID: <1b786481c7a4f580d8b045df92c381fd33e08e9c.camel@posteo.net> (raw)
In-Reply-To: <87ftgjc7js.fsf@cbaines.net>

On Mon, 2020-01-13 at 22:31 +0000, Christopher Baines wrote:
> Kei Kebreau <kkebreau@posteo.net> writes:
> 
> > * gnu/packages/games.scm (red-eclipse): Update to 2.0.0.
> > [source]: Remove obsolete patch, and fetch submodules making
> > recursive true.
> > [arguments]: Remove "unpack-data" phase and adjust
> > "add-store-data-package-path-as-default" phase.
> > [inputs]: Add freetype and remove data-sources.
> > * gnu/packages/patches/red-eclipse-remove-gamma-name-hack.patch:
> > Delete file.
> > * gnu/local.mk (dist_patch_DATA): Delete file.
> > ---
> >  gnu/local.mk                                  |  1 -
> >  gnu/packages/games.scm                        | 96 +++----------
> > ------
> >  .../red-eclipse-remove-gamma-name-hack.patch  | 52 ----------
> >  3 files changed, 12 insertions(+), 137 deletions(-)
> >  delete mode 100644 gnu/packages/patches/red-eclipse-remove-gamma-
> > name-hack.patch
> 
> Looks good to me :) The changes look good, I like that the package
> definition is a little shorter. I've successfully built the package
> on
> x86_64-linux, and launched the game.

I just built and tested i686-linux version of the game with no issues. 
Pushed to master with your help.  Thank you!

Kei

      reply	other threads:[~2020-01-16  3:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13  1:32 [bug#39109] [PATCH] gnu: red-eclipse: Update to 2.0.0 Kei Kebreau
2020-01-13 22:31 ` Christopher Baines
2020-01-16  3:47   ` Kei Kebreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b786481c7a4f580d8b045df92c381fd33e08e9c.camel@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=39109-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).