From: Julien Lepiller <julien@lepiller.eu>
Cc: 27937@debbugs.gnu.org
Subject: [bug#27937] Update php to 7.1.8
Date: Fri, 04 Aug 2017 08:30:08 +0200 [thread overview]
Message-ID: <1C708BD2-82DE-4838-8FDD-DE1B3AA71E36@lepiller.eu> (raw)
In-Reply-To: <20170803222010.GB2421@jasmine.lan>
Le 4 août 2017 00:20:10 GMT+02:00, Leo Famulari <leo@famulari.name> a écrit :
>On Thu, Aug 03, 2017 at 08:22:00PM +0200, Julien Lepiller wrote:
>> Hi,
>>
>> a new version of php has been released. Here is a patch to update it.
>
>> From 49de4d05b1b292af598755bfa7754661519218b8 Mon Sep 17 00:00:00
>2001
>> From: Julien Lepiller <julien@lepiller.eu>
>> Date: Thu, 3 Aug 2017 20:14:56 +0200
>> Subject: [PATCH] gnu: php: Update to 7.1.8.
>>
>> * gnu/packages/patches/gd-CVE-2017-7890.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it
>> * gnu/packages/php.scm (php): Update to 7.1.8.
>
>Thanks! Overall LGTM.
>
>Could this close <https://bugs.gnu.org/27808>?
>
I think it does
>> diff --git a/gnu/packages/patches/gd-CVE-2017-7890.patch
>b/gnu/packages/patches/gd-CVE-2017-7890.patch
>> new file mode 100644
>> index 000000000..743fc6d3d
>> --- /dev/null
>> +++ b/gnu/packages/patches/gd-CVE-2017-7890.patch
>> @@ -0,0 +1,30 @@
>> +From 99ba5c353373ed198f54af66fe4e355ebb96e363 Mon Sep 17 00:00:00
>2001
>> +From: LEPILLER Julien <julien.lepiller@irisa.fr>
>> +Date: Thu, 3 Aug 2017 17:04:17 +0200
>> +Subject: [PATCH] Fix #399: Buffer over-read into uninitialized
>memory.
>> +
>> +The stack allocated color map buffers were not zeroed before usage,
>and
>> +so undefined palette indexes could cause information leakage.
>> +
>> +This is CVE-2017-7890.
>
>Would this patch be valuable for the "regular" gd package as well, or
>is
>it specific to gd-for-php?
It could be used for gd, but I think it would trigger a lot of rebuilds. I'm not confident with how the graft mechanism works, so I would need some help.
>
>> +(define gd-for-php
>> + (package
>> + (inherit gd)
>> + (source (origin
>> + (inherit (package-source gd))
>> + (patches (search-patches "gd-fix-gd2-read-test.patch"
>> + "gd-fix-tests-on-i686.patch"
>> +
>"gd-freetype-test-failure.patch"
>> +
>"gd-php-73968-Fix-109-XBM-reading.patch"
>> + "gd-CVE-2017-7890.patch"))))))
> ^
> This indentation is too far to the left.
Arg... those are tabs I guess. Thanks for the review! I will push it this evening if everything is ok.
next prev parent reply other threads:[~2017-08-04 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 18:22 [bug#27937] Update php to 7.1.8 Julien Lepiller
2017-08-03 22:20 ` Leo Famulari
2017-08-04 6:30 ` Julien Lepiller [this message]
2017-08-04 15:01 ` Leo Famulari
2017-08-05 8:02 ` Julien Lepiller
2017-09-04 13:16 ` bug#27937: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1C708BD2-82DE-4838-8FDD-DE1B3AA71E36@lepiller.eu \
--to=julien@lepiller.eu \
--cc=27937@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).