unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Sergey Trofimov <sarg@sarg.org.ru>, 62228@debbugs.gnu.org
Cc: 宋文武 <iyzsong@envs.net>, "Bruno Victal" <mirai@makinata.eu>,
	"Liliana Marie Prikler" <liliana.prikler@gmail.com>,
	"Adam Faiz" <adam.faiz@disroot.org>
Subject: [bug#62228] [PATCH v4 3/3] gnu: Add sgt-puzzles.
Date: Tue, 12 Mar 2024 08:50:34 +0100	[thread overview]
Message-ID: <1935dcacde26220e2e9f865802269ece06e5f504.camel@ist.tugraz.at> (raw)
In-Reply-To: <4389dc229183f814581dd5ca87c12157ac81c744.1710228453.git.sarg@sarg.org.ru>

Am Dienstag, dem 12.03.2024 um 08:28 +0100 schrieb Sergey Trofimov:
> * gnu/packages/games.scm (sgt-puzzles): New variable.
> ---
>  gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 9ff08e5e74..94aa9e9140 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -938,6 +938,40 @@ (define-public rogue
>      (home-page "https://github.com/Davidslv/rogue")
>      (license license:bsd-3)))
>  
> +(define-public sgt-puzzles
> +  (package
> +    (name "sgt-puzzles")
> +    (version "20240302.80aac31")
It is still unclear where this version string comes from.  See section
22.5.3 Version Numbers in the manual for the correct layout.
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> "https://git.tartarus.org/simon/puzzles.git")
> +                    (commit
> "80aac3104096aee4057b675c53ece8e60793aa90")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0z4clv0xi98q28riz323ppn165cm62gj1c6h3xdd2sym4v8gy65z"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list #:tests? #f ;No tests.
> +           #:configure-flags #~(list "-DNAME_PREFIX=sgt-")
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'set-xdg-open-path
> +                          (lambda _
> +                            (substitute* "gtk.c"
> +                              (("(#define HELP_BROWSER_PATH ).+" all
> define)
> +                               (string-append define "\""
> +                                              #$(this-package-input
> +                                                 "xdg-utils")
> +                                              "/bin/xdg-
> open\"\n"))))))))
Use search-input-file instead.  You might also want to dedent this
whole thing a little to save some horizontal real-estate and fit one-
liners into one line, actually.
> +    (inputs (list gtk+ xdg-utils))
> +    (native-inputs (list pkg-config perl imagemagick halibut))
> +    (home-page
> "https://www.chiark.greenend.org.uk/~sgtatham/puzzles/")
> +    (synopsis "Simon Tatham's portable puzzle collection")
> +    (description
> +     "Simon Tatham's Portable Puzzle Collection contains a number of
> +popular puzzle games for one player.")
> +    (license license:expat)))
Cheers

  reply	other threads:[~2024-03-12  7:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 21:19 [bug#62228] [PATCH 0/2] gnu: Add sgt-puzzles Sergey Trofimov
2023-03-16 21:24 ` [bug#62228] [PATCH 1/2] gnu: Add halibut Sergey Trofimov
2023-03-16 21:24 ` Sergey Trofimov
2023-03-17  7:50   ` Liliana Marie Prikler
2023-03-17 13:15     ` Bruno Victal
2023-03-17 17:16       ` Liliana Marie Prikler
2023-03-16 21:25 ` [bug#62228] [PATCH 2/2] gnu: Add sgt-puzzles Sergey Trofimov
2023-03-17  3:05   ` Bruno Victal
2023-03-16 21:46 ` [bug#62228] [PATCH] " Sergey Trofimov
2023-03-17  7:40 ` [bug#62228] [PATCH v1] " Sergey Trofimov
2023-03-17  8:29 ` [bug#62228] [PATCH v2 1/3] gnu: Prefix licenses in documentation.scm Sergey Trofimov
2023-03-17  8:29   ` [bug#62228] [PATCH v2 2/3] gnu: Add halibut Sergey Trofimov
2023-03-17  8:29   ` [bug#62228] [PATCH v2 3/3] gnu: Add sgt-puzzles Sergey Trofimov
2024-03-10 21:36 ` [bug#62228] [PATCH v3 1/3] gnu: Prefix licenses in documentation.scm Sergey Trofimov
2024-03-10 21:36   ` [bug#62228] [PATCH v3 2/3] gnu: Add halibut Sergey Trofimov
2024-03-10 21:36   ` [bug#62228] [PATCH v3 3/3] gnu: Add sgt-puzzles Sergey Trofimov
2024-03-11 19:31     ` Liliana Marie Prikler
2024-03-11 19:31   ` [bug#62228] [PATCH v3 1/3] gnu: Prefix licenses in documentation.scm Liliana Marie Prikler
2024-03-12  7:28 ` [bug#62228] [PATCH v4 " Sergey Trofimov
2024-03-12  7:28   ` [bug#62228] [PATCH v4 2/3] gnu: Add halibut Sergey Trofimov
2024-03-12  7:28   ` [bug#62228] [PATCH v4 3/3] gnu: Add sgt-puzzles Sergey Trofimov
2024-03-12  7:50     ` Liliana Marie Prikler [this message]
2024-03-12  8:11       ` Sergey Trofimov
2024-03-12 16:47 ` [bug#62228] [PATCH v5 1/3] gnu: Prefix licenses in documentation.scm Sergey Trofimov
2024-03-12 16:47   ` [bug#62228] [PATCH v5 2/3] gnu: Add halibut Sergey Trofimov
2024-03-12 16:47   ` [bug#62228] [PATCH v5 3/3] gnu: Add sgt-puzzles Sergey Trofimov
2024-03-17 12:32     ` bug#62228: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1935dcacde26220e2e9f865802269ece06e5f504.camel@ist.tugraz.at \
    --to=liliana.prikler@ist.tugraz.at \
    --cc=62228@debbugs.gnu.org \
    --cc=adam.faiz@disroot.org \
    --cc=iyzsong@envs.net \
    --cc=liliana.prikler@gmail.com \
    --cc=mirai@makinata.eu \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).