From: Maxime Devos <maximedevos@telenet.be>
To: Zhu Zihao <all_but_last@163.com>, Oleg Pykhalov <go.wigust@gmail.com>
Cc: 51747@debbugs.gnu.org
Subject: [bug#51747] [PATCH]: gnu: nix: Update to 2.4.
Date: Tue, 11 Jan 2022 20:04:17 +0100 [thread overview]
Message-ID: <190ec030edbca1c16fb030c51acd60ffc6bae269.camel@telenet.be> (raw)
In-Reply-To: <86pmoyrxyy.fsf@163.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Zhu Zihao schreef op wo 12-01-2022 om 01:19 [+0800]:
> + (name "libcpuid") [...]
> + (supported-systems '("x86_64-linux" "i686-linux"))
Given that 'cpuid' is a CPU instruction, I don't think
this is Linux-specific; presumably it works on the Hurd
as well. According to the README, it also supports some BSDs,
Mac OS and Windows!
Could you change it to
(filter (lambda (t) (or (x86-64-target? t) (or (x86-32-target? t))))
%supported-systems)
instead (untested)?
Also, the source code contains a blob
<https://github.com/anrieff/libcpuid/blob/master/libcpuid/msrdriver.c>,
could you remove it in an origin snippet?
There might be more blobs, I didn't look at all files.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-01-11 19:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:35 [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Zhu Zihao
[not found] ` <handler.51747.B.16365478179399.ack@debbugs.gnu.org>
2021-11-10 13:53 ` [bug#51747] Acknowledgement ([PATCH]: gnu: nix: Update to 2.4. ) Zhu Zihao
2021-11-10 15:47 ` Zhu Zihao
2021-11-17 11:21 ` Zhu Zihao
2021-12-04 15:28 ` Zhu Zihao
2022-01-11 8:23 ` [bug#51747] [PATCH]: gnu: nix: Update to 2.4 Oleg Pykhalov
2022-01-11 9:46 ` Zhu Zihao
2022-01-11 17:19 ` Zhu Zihao
2022-01-11 19:04 ` Maxime Devos [this message]
2022-01-12 4:21 ` Zhu Zihao
2022-01-12 5:19 ` Oleg Pykhalov
2022-01-12 7:08 ` Zhu Zihao
2022-01-12 8:26 ` Maxime Devos
2022-01-13 4:54 ` Zhu Zihao
2022-01-13 7:54 ` Zhu Zihao
2022-01-14 13:06 ` Maxime Devos
2022-01-14 16:51 ` Zhu Zihao
2022-01-14 18:39 ` Maxime Devos
2022-01-15 1:58 ` Zhu Zihao
2022-01-15 5:47 ` Zhu Zihao
2022-01-15 10:52 ` Maxime Devos
2022-01-15 16:06 ` Zhu Zihao
2022-01-21 14:29 ` bug#51747: " Oleg Pykhalov
2022-01-23 11:02 ` [bug#51747] " Maxime Devos
2022-01-11 19:05 ` Maxime Devos
2022-01-14 9:31 ` Zhu Zihao
2022-01-14 12:56 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190ec030edbca1c16fb030c51acd60ffc6bae269.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=51747@debbugs.gnu.org \
--cc=all_but_last@163.com \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).